Fix wallet confirm under serve for passkey sealed approvals#98
Open
0xdewy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bloom wallet confirmthrough plain IPCwriteinstead ofwrite_unlockedPermissionDenied, run the foreground Sealed Approval ceremony, writeapproval.json, and retry the same writeChecklist
docs/architecture/) updated if contracts or behavior changed - N/A, this preserves the existing Sealed Approval/VFS contract and fixes the CLI routecrates/bloom-vfs/src/docs/agent-guidance.mdand affected Petal READMEs) - N/A, no agent-facing VFS surface or Petal guidance changedVerification
cargo fmtcargo test -p bloom wallet_confirm_uses_plain_ipc_write_when_socket_exists -- --nocapturecargo test -p bloom-daemon passkey_write_unlocked_is_hard_disabled -- --nocapturecargo test -p bloom-vfs approval_challenge_is_visible_and_read_only -- --nocapturecargo check -p bloomgit diff --checkCloses #90