Skip to content

Assert no schemalk during distributed commit #5680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
markhannum wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Assert no schemalk during distributed commit #5680

markhannum wants to merge 1 commit into from
+110 −35

Conversation

@markhannum
Copy link
Contributor

@markhannum markhannum commented Jan 21, 2026

This PR cleans up cases where we call distributed-commit unnecessarily.

roborivers
roborivers suggested changes Jan 21, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 18/639 tests failed ⚠.

The first 10 failing tests are:
queuedb_multimeta [core dumped]
rowlock_update [core dumped]
queuedb_locks [core dumped]
consumer_snapshot_generated [core dumped]
consumer [core dumped]
vutf8_rowlocks [core dumped]
vutf8_rowlocks_off_osql_odh_blob_generated [core dumped]
sql [core dumped]
trigger_lock_inversion [core dumped]
truncatesc_offline_generated

@markhannum markhannum force-pushed the assert_no_schemalk branch 2 times, most recently from 456aea0 to c94856a Compare January 21, 2026 20:16
roborivers
roborivers approved these changes Jan 21, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
queuedb_rollover
reco-ddlk-sql

@markhannum markhannum force-pushed the assert_no_schemalk branch 2 times, most recently from eefda31 to 4b5518e Compare January 22, 2026 00:54
roborivers
roborivers suggested changes Jan 22, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_resume
sc_transactional_rowlocks_generated
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql

@markhannum markhannum force-pushed the assert_no_schemalk branch 8 times, most recently from 2acb45c to 48afc46 Compare January 23, 2026 22:46
@markhannum
Copy link
Contributor Author

markhannum commented Jan 23, 2026

/plugin-branch assert_no_schemalk_plugins

@markhannum markhannum force-pushed the assert_no_schemalk branch 3 times, most recently from 37dc696 to 57d41e7 Compare January 24, 2026 00:38
@markhannum
Assert no schemalk during distributed commit
1bdc40a 
Signed-off-by: Mark Hannum <mhannum@bloomberg.net>
roborivers
roborivers suggested changes Jan 24, 2026
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@roborivers roborivers roborivers requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markhannum @roborivers