fix - capturing incorrect rc of ./runit in runtestcase #5686
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishitha Kalicheti <rkalicheti1@bloomberg.com>
roborivers
suggested changes
Jan 22, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.
roborivers
approved these changes
Jan 23, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
analyze
analyze_partial_index_off_generated
renametable_lightweight_generated
renametable
selectv_timepart
consumer_non_atomic_default_consumer_generated
auth_twofiles_generated
auth_queueodh_generated
auth
userschema_queueodh_generated
dorinhogea
reviewed
Jan 23, 2026
|
|
||
| testdb_note "test start" | ||
| timeout --kill-after=5s ${TEST_TIMEOUT} stdbuf -oL -eL bash -c "./runit ${DBNAME} 2>&1 | gawk '{ print strftime(\"%H:%M:%S>\"), \$0; fflush(); }'" &> ${TESTDIR}/logs/${DBNAME}.testcase | ||
| timeout --kill-after=5s ${TEST_TIMEOUT} stdbuf -oL -eL bash -c "set -o pipefail; ./runit ${DBNAME} 2>&1 | gawk '{ print strftime(\"%H:%M:%S>\"), \$0; fflush(); }'" &> ${TESTDIR}/logs/${DBNAME}.testcase |
Contributor
There was a problem hiding this comment.
should we check for timeout $? before checking the pipeline status?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix runtestcase reporting failures as success