feat: Add onSelectionChange event for native text selection detection#41
Open
yacinebaroudi wants to merge 4 commits into
Open
feat: Add onSelectionChange event for native text selection detection#41yacinebaroudi wants to merge 4 commits into
yacinebaroudi wants to merge 4 commits into
Conversation
- Add onSelectionChange event to RNUITextViewNativeComponent - Implement UITextViewDelegate in RNUITextView.mm - Add textViewDidChangeSelection delegate method with event emission - Add comprehensive NSLog debugging for selection changes - Update Text.tsx to support onSelectionChange prop with useCallback - Add JSDoc documentation for SelectionChangeEvent interface This replaces polling-based selection detection with real-time native events, providing instant selection change notifications and eliminating CPU overhead.
__DEV__ is not available in Objective-C++ context. Use standard Objective-C preprocessor directive #if DEBUG instead.
Temporarily use source files instead of built lib files to enable local development without requiring build step.
|
will this feature be added to the library? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds native
onSelectionChangeevent toUITextViewcomponent, enabling real-time text selection detection without polling.Motivation
React Native's default
Textcomponent doesn't support text selection on iOS. TheUITextViewcomponent provides native selection UI, but there was no way to detect when selection changes. This feature enables:Changes
Native (iOS)
RNUITextViewtoUITextViewDelegateprotocoltextViewDidChangeSelection:delegate methodonSelectionChangeevents via React Native event emitterTypeScript
SelectionChangeEventinterface toRNUITextViewNativeComponent.tsonSelectionChangeprop toNativePropsuseCallbackinText.tsxfor performanceDocumentation
CHANGELOG.mdwith feature descriptionTesting
Breaking Changes
None. This is a purely additive feature.