chore: remove dead namespace-scope _attributedString#48
Draft
haileyok wants to merge 1 commit into
Draft
Conversation
The class declares a mutable _attributedString member, which shadows this namespace-scope variable in unqualified name lookup, so the namespace variable is never read or written. Deleting it removes the footgun: if the member were ever removed from the header, lookup would silently fall through to a single shared global and every shadow node instance would trample the others' state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drive-by cleanup spotted while working on #21.
RNUITextViewShadowNode.hdeclares amutable AttributedString _attributedStringmember.RNUITextViewShadowNode.cpp:15also defined anAttributedString _attributedString = AttributedString{};at namespace scope. In C++, unqualified name lookup inside a member function searches class scope before enclosing namespace scope, so every reference to_attributedStringinmeasureContentandlayoutalready binds to the member — the namespace-scope variable is shadowed, never read, never written.Today this is harmless dead code. The reason to delete it: if anyone ever removes the member from the header thinking it's redundant with the cpp definition, name lookup silently falls through to the global and every shadow node instance will start trampling the others' state. Removing the global makes the intent obvious and defuses the footgun.
No behavior change. The member-resolution semantics are unchanged.
Test plan
pod installand build the example app succeeds.onTextLayoutbehavior unchanged in the example app.🤖 Generated with Claude Code