fix: map textDecorationStyle 'double' to Double, not Dotted#49
Draft
haileyok wants to merge 1 commit into
Draft
Conversation
The fourth branch checks Dotted again instead of Double, so the Double case is unreachable and 'double' silently falls back to whatever the default decoration style is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spotted during a code-review pass.
RNUITextViewShadowNode.cpp:99checksRNUITextViewChildTextDecorationStyle::Dottedfor the second time, so the branch that was supposed to setTextDecorationStyle::Doubleis unreachable. Result: `textDecorationStyle: 'double'` silently doesn't render as a double underline — it falls through to whatever the default is.One-character fix.
Test plan
🤖 Generated with Claude Code