Skip to content

feat: add impact assessment agent - #2593

Open
santanug5ai wants to merge 4 commits into
bmad-code-org:mainfrom
santanug5ai:feat/impact-assessment-agent
Open

feat: add impact assessment agent#2593
santanug5ai wants to merge 4 commits into
bmad-code-org:mainfrom
santanug5ai:feat/impact-assessment-agent

Conversation

@santanug5ai

Copy link
Copy Markdown

What

Add a new Impact Assessment Agent skill and documentation to the BMM skill set for evaluating change impact, dependencies, and mitigation options.

Why

This contribution provides a focused agent persona that helps teams assess business and technical impact before implementation, improving planning quality and decision support.

How

  • Added a new BMAD skill under the planning workflow module for the Impact Assessment Agent
  • Defined the persona, principles, and menu prompt for impact analysis
  • Added documentation and example prompts for usage

Testing

Verified the new contribution files are present in the repository and pushed the branch for review.

@santanug5ai
santanug5ai marked this pull request as ready for review July 15, 2026 10:38
@github-actions

Copy link
Copy Markdown
Contributor

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Adds an Impact Assessment Agent skill with configurable Iris persona, activation workflow, assessment menu command, persistent project context loading, and documentation covering use cases and example prompts.

Changes

Impact Assessment Agent

Layer / File(s) Summary
Agent configuration and activation
src/bmm-skills/2-plan-workflows/bmad-agent-impact-assessment/customize.toml, src/bmm-skills/2-plan-workflows/bmad-agent-impact-assessment/SKILL.md
Defines the Iris persona, assessment principles, IMPACT command, project-context loading, customization resolution, language configuration, and interaction flow.
Agent documentation
docs/impact-assessment-agent.md
Describes the agent’s purpose, suggested use cases, and example prompts for impact, risk, dependency, and rollout analysis.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding an impact assessment agent.
Description check ✅ Passed The description accurately matches the added agent skill, documentation, and purpose of impact analysis.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/bmm-skills/2-plan-workflows/bmad-agent-impact-assessment/SKILL.md`:
- Around line 44-46: Update the Iris activation flow in SKILL.md to execute
`{agent.activation_steps_append}` after the persona becomes active and before
responding directly or rendering `{agent.menu}` and waiting for user input.
Preserve the existing behavior for impact-assessment requests and menu handling.
- Around line 21-23: Update the Step 1 “Resolve the Agent Block” instructions to
invoke resolve_customization.py with uv run instead of python3. Instruct the
agent to apply the loaded customization context and activation steps, handle
resolution failures, incorporate {agent.persistent_facts}, and prepend
{agent.activation_steps_prepend} before continuing.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2683fb72-99f4-4923-8dbc-8e1b09dbf580

📥 Commits

Reviewing files that changed from the base of the PR and between 1cd4a7f and 0f1a78c.

⛔ Files ignored due to path filters (1)
  • src/bmm-skills/module-help.csv is excluded by !**/*.csv
📒 Files selected for processing (3)
  • docs/impact-assessment-agent.md
  • src/bmm-skills/2-plan-workflows/bmad-agent-impact-assessment/SKILL.md
  • src/bmm-skills/2-plan-workflows/bmad-agent-impact-assessment/customize.toml

Comment thread src/bmm-skills/2-plan-workflows/bmad-agent-impact-assessment/SKILL.md Outdated
santanug5ai and others added 2 commits July 15, 2026 13:26
…KILL.md


update changes

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…KILL.md


update changes2

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

@santanug5ai santanug5ai left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated review comments . please review

@santanug5ai santanug5ai left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review

@santanug5ai

Copy link
Copy Markdown
Author

can you please review and approve the workflow..

@santanug5ai santanug5ai left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes done..please review.

@bmadcode

Copy link
Copy Markdown
Collaborator

I do not think this requires a whole new agent @santanug5ai for the single prompt. we already have the business analyst and product manager either of which could have an internal capability added for doing this analysis.

@santanug5ai

santanug5ai commented Jul 22, 2026

Copy link
Copy Markdown
Author

I do not think this requires a whole new agent @santanug5ai for the single prompt. we already have the business analyst and product manager either of which could have an internal capability added for doing this analysis.

Thank you @bmadcode for your comment. My focus is on a deep technical impact analysis agent that can leverage the entire enterprise context against business requirements, enabling Business Analysts and Product Managers to assess technical impacts effectively. However, a single agent is unlikely to provide comprehensive, in-depth analysis across all interconnected enterprise components. Such analysis would typically require a multi-agent or specialized domain-agent approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants