feat: add impact assessment agent - #2593
Conversation
|
@coderabbitai review |
📝 WalkthroughWalkthroughAdds an Impact Assessment Agent skill with configurable Iris persona, activation workflow, assessment menu command, persistent project context loading, and documentation covering use cases and example prompts. ChangesImpact Assessment Agent
Estimated code review effort: 1 (Trivial) | ~4 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/bmm-skills/2-plan-workflows/bmad-agent-impact-assessment/SKILL.md`:
- Around line 44-46: Update the Iris activation flow in SKILL.md to execute
`{agent.activation_steps_append}` after the persona becomes active and before
responding directly or rendering `{agent.menu}` and waiting for user input.
Preserve the existing behavior for impact-assessment requests and menu handling.
- Around line 21-23: Update the Step 1 “Resolve the Agent Block” instructions to
invoke resolve_customization.py with uv run instead of python3. Instruct the
agent to apply the loaded customization context and activation steps, handle
resolution failures, incorporate {agent.persistent_facts}, and prepend
{agent.activation_steps_prepend} before continuing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2683fb72-99f4-4923-8dbc-8e1b09dbf580
⛔ Files ignored due to path filters (1)
src/bmm-skills/module-help.csvis excluded by!**/*.csv
📒 Files selected for processing (3)
docs/impact-assessment-agent.mdsrc/bmm-skills/2-plan-workflows/bmad-agent-impact-assessment/SKILL.mdsrc/bmm-skills/2-plan-workflows/bmad-agent-impact-assessment/customize.toml
…KILL.md update changes Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…KILL.md update changes2 Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
santanug5ai
left a comment
There was a problem hiding this comment.
updated review comments . please review
|
can you please review and approve the workflow.. |
santanug5ai
left a comment
There was a problem hiding this comment.
changes done..please review.
|
I do not think this requires a whole new agent @santanug5ai for the single prompt. we already have the business analyst and product manager either of which could have an internal capability added for doing this analysis. |
Thank you @bmadcode for your comment. My focus is on a deep technical impact analysis agent that can leverage the entire enterprise context against business requirements, enabling Business Analysts and Product Managers to assess technical impacts effectively. However, a single agent is unlikely to provide comprehensive, in-depth analysis across all interconnected enterprise components. Such analysis would typically require a multi-agent or specialized domain-agent approach. |
What
Add a new Impact Assessment Agent skill and documentation to the BMM skill set for evaluating change impact, dependencies, and mitigation options.
Why
This contribution provides a focused agent persona that helps teams assess business and technical impact before implementation, improving planning quality and decision support.
How
Testing
Verified the new contribution files are present in the repository and pushed the branch for review.