Fix ip & tcp header calculation in memcache command - #20
Closed
allenlz wants to merge 1 commit into
Closed
Conversation
Owner
|
Hello, thank you for your PR. I think it might be more useful to see the patch as an 'Add Binary Protocol Support' patch. Do you think you could update it with the other changes for adding binary support? |
Author
|
sure. please see #21 |
Owner
|
Closing in favor of #21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, it's my first time to use pull request.
I'm impressed by memkeys's work.
Since we also need it to find hot keys, I studied it a little bit and focused on the memcache command processing.
I found it ignores some part in IP & TCP head. Although, it's not a big deal, as it only accept alpha bytes in following 'makeResponse' function.
But I need to process binary protocol, so I fixed it. Hope it helps.
And I also implemented mget support and binary protocol support. If you need it, I can send those as pull requests too.