[pull] dev from KelvinTegelaar:dev#962
Open
pull[bot] wants to merge 188 commits intobmsimp:devfrom
Open
Conversation
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
[pull] dev from KelvinTegelaar:dev
**Important:** This PR is dependant on JohnDuprey/DNSHealth#26 being merged and the module updated in CIPP Implement AutoDiscover record validation in the domain analysis process and enhance the domain health listing functionality to support AutoDiscover record retrieval. Frontend PR: KelvinTegelaar/CIPP#5974
…#2041) ## Summary - Adds optional `usageLocation` (ISO 3166-1 alpha-2) to JIT Admin user creation via Graph API - Saves `defaultUsageLocation` in JIT Admin templates (both Add and Edit) - Prevents Huntress false-positive alerts for JIT Admin accounts missing usage location Fixes KelvinTegelaar/CIPP#5910 Companion PR (frontend): KelvinTegelaar/CIPP#5971 ## Changes - `Set-CIPPUserJITAdmin.ps1` — conditionally includes `usageLocation` in the Graph POST body when creating users - `Invoke-ExecJITAdmin.ps1` — passes `usageLocation` from request body to the User hashtable - `Invoke-AddJITAdminTemplate.ps1` — saves `defaultUsageLocation` in template object - `Invoke-EditJITAdminTemplate.ps1` — same for template editing
- Updated Set-CIPPManager and Set-CIPPSponsor functions to accept multiple users for bulk processing. - Modified Invoke-EditUser and Invoke-PatchUser to handle bulk updates for managers and sponsors. - Enhanced logging for success and error messages during updates.
The autocomplete component sends {label, value} objects but the
Graph API expects a plain string for usageLocation. Extract .value
before passing to API, matching the pattern used by other user
endpoints (Invoke-AddUserDefaults, Invoke-EditUser, etc).
The usageLocation autocomplete sends {label, value} objects but Graph
API
expects a plain string. This causes a "StartObject node found for
usageLocation, PrimitiveValue expected" error when creating JIT Admin
users.
Extract .value before passing to the API, same as Invoke-AddUserDefaults
and Invoke-EditUser already do.
Enable bulk processing for setting multiple managers and sponsors in user updates. Introduce 'manager' and 'sponsor' properties to the user patching functionality. Frontend PR: KelvinTegelaar/CIPP#5976
… reseller relationship links implements KelvinTegelaar/CIPP#5963
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )