add Request body methods - #5322
Open
Monti-27 wants to merge 4 commits into
Open
Conversation
github-actions
Bot
added
the
Waiting On Review
github-actions
Bot
added
C-Tests
Test262 conformance changes
Tested main commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5322 +/- ##
===========================================
+ Coverage 47.24% 59.74% +12.49%
===========================================
Files 476 591 +115
Lines 46892 63749 +16857
===========================================
+ Hits 22154 38084 +15930
- Misses 24738 25665 +927 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
HalidOdat
reviewed
Apr 14, 2026
jedel1043
requested changes
Jul 24, 2026
Comment on lines
+5
to
+35
| pub(super) fn bytes(body: Rc<Vec<u8>>, context: &mut Context) -> JsPromise { | ||
| JsPromise::from_async_fn( | ||
| async move |context| { | ||
| JsUint8Array::from_iter(body.iter().copied(), &mut context.borrow_mut()).map(Into::into) | ||
| }, | ||
| context, | ||
| ) | ||
| } | ||
|
|
||
| pub(super) fn text(body: Rc<Vec<u8>>, context: &mut Context) -> JsPromise { | ||
| JsPromise::from_async_fn( | ||
| async move |_| { | ||
| let body = String::from_utf8_lossy(body.as_ref()); | ||
| Ok(JsString::from(body).into()) | ||
| }, | ||
| context, | ||
| ) | ||
| } | ||
|
|
||
| pub(super) fn json(body: Rc<Vec<u8>>, context: &mut Context) -> JsPromise { | ||
| JsPromise::from_async_fn( | ||
| async move |context| { | ||
| let json_string = String::from_utf8_lossy(body.as_ref()); | ||
| let json = serde_json::from_str::<serde_json::Value>(&json_string) | ||
| .map_err(|e| JsNativeError::syntax().with_message(e.to_string()))?; | ||
|
|
||
| JsValue::from_json(&json, &mut context.borrow_mut()) | ||
| }, | ||
| context, | ||
| ) | ||
| } |
Member
There was a problem hiding this comment.
Why are you using async functions here? I don't see any awaits in the callbacks, so you could use a plain JsPromise::new
jedel1043
added
Waiting On Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5321
This adds the Body methods currently supported by Boa to
Request, and tracks body usage soRequestcloning and transfer behave correctly.Tests: