Skip to content

fix(parser): parse default async arrow exports #5445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AayushMainali-Github wants to merge 1 commit into
base: main
Choose a base branch
from
+36 −10
Open

fix(parser): parse default async arrow exports #5445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions core/parser/src/parser/statement/declaration/export.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,17 +184,27 @@ where
}
}
TokenKind::Keyword((Keyword::Async, false)) => {
let next_token = cursor.peek(2, interner).or_abrupt()?;
if next_token.kind() == &TokenKind::Punctuator(Punctuator::Mul) {
AstExportDeclaration::DefaultAsyncGeneratorDeclaration(
AsyncGeneratorDeclaration::new(false, true, true)
.parse(cursor, interner)?,
)
let next_token = cursor.peek(1, interner).or_abrupt()?;
if next_token.kind() == &TokenKind::Keyword((Keyword::Function, false)) {
let following_token = cursor.peek(2, interner).or_abrupt()?;
if following_token.kind() == &TokenKind::Punctuator(Punctuator::Mul) {
AstExportDeclaration::DefaultAsyncGeneratorDeclaration(
AsyncGeneratorDeclaration::new(false, true, true)
.parse(cursor, interner)?,
)
} else {
AstExportDeclaration::DefaultAsyncFunctionDeclaration(
AsyncFunctionDeclaration::new(false, true, true)
.parse(cursor, interner)?,
)
}
} else {
AstExportDeclaration::DefaultAsyncFunctionDeclaration(
AsyncFunctionDeclaration::new(false, true, true)
.parse(cursor, interner)?,
)
let expr = AssignmentExpression::new(true, false, true)
.parse(cursor, interner)?;

cursor.expect_semicolon("default expression export", interner)?;

AstExportDeclaration::DefaultAssignmentExpression(expr)
}
}
TokenKind::Keyword((Keyword::Class, false)) => {
Expand Down
16 changes: 16 additions & 0 deletions core/parser/src/parser/statement/declaration/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,6 +663,22 @@ fn import_non_string_attribute_value() {
);
}

/// Checks async arrow functions in default exports.
#[test]
fn default_export_async_arrow_function() {
let scope = boa_ast::scope::Scope::new_global();

for source in [
"export default async () => 1;",
"export default async x => x;",
"export default async (a, b) => a + b;",
] {
Parser::new(Source::from_bytes(source))
.parse_module(&scope, &mut Interner::default())
.expect("async arrow function should parse as a default export");
}
}

/// Checks `using` declaration parsing.
#[test]
fn using_declaration() {
Expand Down