docs(engine): note why TryFromJs omits f32 - #5455
Open
AayushMainali-Github wants to merge 2 commits into
Open
Conversation
Make the intentional omission discoverable so users convert via f64 (or from_js_with / to_f32) instead of filing another issue.
github-actions
Bot
added
the
Waiting On Review
hansl
approved these changes
Jul 28, 2026
Test262 conformance changes
Tested main commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TryFromJsintentionally omitsf32because JS numbers aref64and thef32cast is lossyf64+ explicitas f32,#[boa(from_js_with = "...")]for derives, orJsValue::to_f32for JS-style coercionTryFromJsis not implemented forf32#5360Test plan
cargo doc -p boa_engine --no-deps