feat(wintertc): migrate abort, encoding and url from boa_runtime - #5463
Open
KaustubhOG wants to merge 3 commits into
Open
feat(wintertc): migrate abort, encoding and url from boa_runtime#5463KaustubhOG wants to merge 3 commits into
KaustubhOG wants to merge 3 commits into
Conversation
Moves `abort` into `boa_wintertc` following the move + re-export pattern established by boa-dev#5418, and points `boa_runtime` at it. The module is unconditional in `boa_wintertc` — `AbortController` and `AbortSignal` are TC55 APIs in their own right, so they should not depend on the `fetch` feature. `boa_runtime` keeps its historical `fetch` gate on the re-export so its public API is unchanged.
Moves `boa_runtime::text` into `boa_wintertc::encoding`, the name the TC55 skeleton reserved for the Encoding Standard APIs, and points `boa_runtime` at it. `boa_runtime::text` stays as a re-export under its historical name, so the public API is unchanged. `bytemuck` moves to `boa_wintertc` along with the module (it was its only user), as does the `test-case` dev-dependency.
Moves `url` into `boa_wintertc` and points `boa_runtime` at it. The only addition to the module is a free `register` entry point wrapping `Url::register`, matching the signature `boa_wintertc::register` expects. The `url` crate moves with the module, so `boa_runtime`'s `url` feature now just forwards to `boa_wintertc/url`. It stays a dev-dependency of `boa_runtime` because the `fetch` e2e tests use it directly.
github-actions
Bot
added
the
Waiting On Review
github-actions
Bot
added
C-Dependencies
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5463 +/- ##
===========================================
+ Coverage 47.24% 62.89% +15.64%
===========================================
Files 476 527 +51
Lines 46892 59020 +12128
===========================================
+ Hits 22154 37120 +14966
+ Misses 24738 21900 -2838 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jedel1043
requested changes
Jul 27, 2026
Comment on lines
+100
to
+108
| //! - `abort` — `AbortController` and `AbortSignal` (requires the `fetch` feature) | ||
| //! - [`base64`] — `atob` and `btoa` | ||
| //! - [`clone`] — `structuredClone` | ||
| //! - [`console`] — the `console` object | ||
| //! - [`microtask`] — `queueMicrotask` | ||
| //! - [`interval`] — the timer APIs (`setTimeout`, `clearTimeout`, `setInterval`, `clearInterval`), | ||
| //! kept under their historical `interval` name | ||
| //! - [`microtask`] — `queueMicrotask` | ||
| //! - [`text`] — `TextEncoder` and `TextDecoder`, kept under their historical `text` name | ||
| //! - `url` — the `URL` class (requires the `url` feature) |
Member
There was a problem hiding this comment.
Missing doc links for url and abort. Is that intentional?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the TC55 migration (#4988), following the move + re-export pattern from #5418.
Clubs the three remaining standalone modules, which are mutually independent and each a mechanical move. They are three separate commits, so I can split them into individual PRs if you prefer. After this,
fetchis the only module left.Changes:
Line counts (before and after, in both locations):
boa_runtime(before)boa_wintertcbeforeboa_wintertcafterabort/mod.rsabort/tests.rsencoding/mod.rs(wastext/mod.rs)encoding/encodings.rsencoding/tests.rsurl/mod.rs(wasurl.rs)url/tests.rs