feat: implement Ephemeron API and Trace trait additions for boa integration - #94
Open
shruti2522 wants to merge 3 commits into
Open
feat: implement Ephemeron API and Trace trait additions for boa integration#94shruti2522 wants to merge 3 commits into
shruti2522 wants to merge 3 commits into
Conversation
shruti2522
marked this pull request as ready for review
July 27, 2026 21:45
shruti2522
marked this pull request as draft
July 27, 2026 21:45
shruti2522
marked this pull request as ready for review
July 28, 2026 17:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to boa-dev/boa#5460, it uncovered some major api gap in our oscars branded api, this pr aims to fill those gaps.
Implement some missing APIs and trait bounds needed to get boa compiling against oscars's null collector.
key()value(),andhas_value()so boa can build a bridging WeakMap implementation. these currently just act as wrappers that always return Some since the null collector never frees anything. I have added TODOs to hook these into the finalization pass when we move to mark_sweep_branded.PoolPointerto?Sizedto supportdyn Traceobjects inboa_enginestd::sync::atomic::Atomic*tuples, and various std collectionsboa_string1,icu_locale_core,eitherandarrayvec. Since orphan rules prevent boa_engine from implementingoscars::Traceon foreign types, we have to implement them here behind feature flags