Conversation
… multiple aggregators.
|
Thanks for your work on this. Could you please review whether this pull request also contains changes that are part of the other pull request on local evaluation? I see several changes that are part of that previous pull request. If that is the case, then perhaps we can work on that first to get that merged and then come back to this pull request. |
…edname generation and deregsiteration non aggregator methods.
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
This folder (.idea) should be ignored. Does this branch need to merge master?
README.md
Outdated
| @@ -0,0 +1,36 @@ | |||
| #BoaEvaluator: Local Mode Boa Compiler | |||
There was a problem hiding this comment.
Remove this - it is in the other pull request
| @@ -0,0 +1,172 @@ | |||
| p: Project = input; | |||
There was a problem hiding this comment.
Move this to 'test/known-good/' ? We dont have an examples directory and if you are going to put code examples in there, might as well use them as test cases.
| jarName = className + ".jar"; | ||
|
|
||
| // make the output directory | ||
| final File outputRoot = new File(new File(System.getProperty("java.io.tmpdir")), UUID.randomUUID().toString()); |
There was a problem hiding this comment.
again, these changes are part of the other pull request
| private boolean possibleInBuiltAgg(String name) { | ||
| Set<String> names = aggregators.keySet(); | ||
| for (final String entry: names) { | ||
| if(entry.contains(name)) { |
There was a problem hiding this comment.
should this be contains()? so if I have a built in named 'top' and I try to use an aggregator 'op' it matches? I think you just want a simple aggregators.containsKey(name) for this function.
| st.add("name", tupType.toJavaType()); | ||
| st.add("fields", fields); | ||
| st.add("types", types); | ||
|
|
| // Arrays.sort(files, new Comparator<File>() { | ||
| // @Override | ||
| // public int compare(File f1, File f2) { | ||
| // int n1 = getNumber(f1.getName()), n2 = getNumber(f2.getName()); |
There was a problem hiding this comment.
why are commented code being changed?
| @@ -16,26 +16,164 @@ | |||
| */ | |||
| Path p = new Path("hdfs://boa-njt/", | ||
| new Path(context.getConfiguration().get("boa.ast.dir", context.getConfiguration().get("boa.input.dir", "repcache/live")), | ||
| new Path("ast"))); | ||
| if(DefaultProperties.localDataPath != null) { |
src/java/boa/runtime/BoaRunner.java
Outdated
| import org.apache.hadoop.mapreduce.Mapper; | ||
| import org.apache.hadoop.util.Tool; | ||
|
|
||
| import boa.datagen.DefaultProperties; |
… has elements of only one type. Adding matrix operations over tuples. Adding a function to convert tuple into array if possible Adding matrix operations into Symbol table Fixing Test for Complex Array types
nmtiwari
force-pushed
the
user_Aggregators
branch
2 times, most recently
from
315acd7 to
8455d9d
Compare
…t operations adding libs for supporting these operations
nmtiwari
force-pushed
the
user_Aggregators
branch
from
8455d9d to
3295b15
Compare
3 participants
User Defined Aggregation support