Skip to content

Union template arguments are not parsable even tho both would end-up in non-empty-string #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boesing wants to merge 1 commit into
base: 1.5.x
Choose a base branch
from
Open

Union template arguments are not parsable even tho both would end-up in non-empty-string #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions tests/acceptance/SprintfNonEmptyString.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,3 +307,16 @@ Feature: non empty template passed to sprintf results in non-empty-string
"""
When I run psalm
Then I see no errors

Scenario: Template is non-empty-string based on union types which are all literal strings with a length > 0
Given I have the following code
"""
$foo = 'bar %s';
if (random_int(0,1) === 1) {
$foo = 'baz %s';
}

nonEmptyString(sprintf($foo, ''));
"""
When I run psalm
Then I see no errors