Let authenticators know the CMD channel TLS state #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@jrouaix please review |
hannesdejager
force-pushed
the
hannes/channel-sec-to-auth
branch
2 times, most recently
from
b713536 to
c31b456
Compare
This allows authenticator implementations to make more informed security-aware decisions by allowing them to know whether the FTP command channel is encrypted or not. So this change modifies the Credentials struct passed to authenticators to include a new field called `command_channel_security` of enum type named `ChannelSecurity`. The USER and PASS command implementations are also modified to set this field from the FTP session state. Towards #478
hannesdejager
force-pushed
the
hannes/channel-sec-to-auth
branch
from
c31b456 to
1d3fb4f
Compare
robklg
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows authenticator implementations to make more informed security-aware decisions by allowing them to know whether the FTP command channel is encrypted or not.
So this change modifies the Credentials struct passed to authenticators to include a new field called
command_channel_securityof enum type namedChannelSecurity.The USER and PASS command implementations are also modified to set this field from the FTP session state.
Towards #478