Fix a case of advance indexing if the list of indices is not sorted.#96
Open
boazmohar wants to merge 1 commit intobolt-project:masterfrom
Open
Fix a case of advance indexing if the list of indices is not sorted.#96boazmohar wants to merge 1 commit intobolt-project:masterfrom
boazmohar wants to merge 1 commit intobolt-project:masterfrom
Conversation
Does not handle sorting keys with dim > 1
Contributor
Author
|
@jwittenbach Can you go over this? |
Contributor
|
@boazmohar sorry for taking so long to get to this. It's looking good to me. Do we have an open issue that it fixes (no worries if we don't)? I'm assuming that, without this fix, the test you wrote would fail when the indices are not ordered, correct? If so, is this just because it did not set the |
Contributor
Author
|
@jwittenbach no there is no open issue, and it is hard for me to remeber now but you also told me to get the order of the keys and not assume they are sorted: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test passes:
This will not: