Version 2.2 by bordaigorl · Pull Request #63 · bordaigorl/rmview

bordaigorl · 2021-04-08T09:36:57Z

New features:

Forwarding of pointer events (see Feature/input emulation #40)
Optional SSH tunneling
Autorotation option
Pointer tracker show delay option
Reuse already running VNC server instances
Support for RM2 v2.6

Blocking on:

VNC server needs to generate proximity events to avoid unwanted palm rejection to be fooled (see Feature/input emulation #40)
VNC server needs to avoid using libcrypto to resolve incompatibility with v2.6

- Refactoring to allow calling protocol methods in fbworker - Adding Pause/Resume - Forwarding keys and pointer events (shift -> pen, clicks -> touch)

- "auto_on_load" detects orientation once at startup - "auto" detects orientation at each update Todo: make detection more reliable

On some platforms there's an unwanted border otherwise.

the config using ssh.password config option.

running.

This should be preffered approach when connecting to remarkable over (W)LAN for security reasons.

run() method. Loading system hosts can easily take 10+ seconds and doing it inside the constructor and not inside run() which runs in a thread pool will block the app and make the main Window freeze since it blocks main qt event loop from running.

better performance.

trademark issues.

…ious_changes

bordaigorl · 2021-04-08T19:50:39Z

@idnovic I spotted a mistake (fixed in c7b5469) but I doubt that is the reason for your issue.
Can you run rmview -v and produce the log?
Have you reinstalled the package using pip install ".[tunnel]"?
Tunnelling seems to be working fine for me...
Would also help to know your OS and RM1/RM2+version.

idnovic · 2021-04-09T12:55:28Z

[INFO] STARTING: Fri Apr  9 14:53:57 2021
[INFO] Searching configuration in rmview.json, /Users/idnovic/Library/Preferences/rmview.json
[DEBUG] Configuration failure in rmview.json: [Errno 2] No such file or directory: 'rmview.json'
[INFO] Fetching configuration from /Users/idnovic/Library/Preferences/rmview.json
[DEBUG] Config values: {'ssh': {'address': '10.124.0.15', 'auth_method': 'password', 'username': 'root', 'password': '********'}, 'orientation': 'portrait', 'pen_size': 15, 'pen_color': 'red', 'pen_trail': 200, 'tunnel': True}
[INFO] Using known hosts file: /Users/idnovic/Library/Preferences/rmview_known_hosts
[INFO] Loaded known hosts from /Users/idnovic/Library/Preferences/rmview_known_hosts
[INFO] Connecting...
[INFO] Connected to 10.124.0.15
[DEBUG] Stopping connection worker
[INFO] Starting VNC server (command=$HOME/rM-vnc-server-standalone)
[INFO] Start command stdout output: 09/04/2021 12:54:06 Listening for VNC connections on TCP port 5900
[INFO] Establishing connection to remote VNC server on 10.124.0.15:5900
[WARNING] Disconnected: Connection was closed cleanly.
[DEBUG] Stopping framebuffer thread...
[INFO] Disconnecting from VNC server...
[INFO] Stopping VNC server...
[DEBUG] Framebuffer thread stopped
[INFO] QUITTING: Fri Apr  9 14:54:14 2021

[INFO] Establishing connection to remote VNC server on 10.124.0.15:5900
[WARNING] Disconnected: Connection was closed cleanly.

The connection is never established.
Everything above is over wifi.

idnovic · 2021-04-09T12:57:48Z

yes I reinstalled the newest dev branch with tunnel support.
I am using macOS 11.2.3 and testet with an reMarkable 2 with version 2.6.2.75. I am also using the newest version of reMarkable Tweaks

bordaigorl · 2021-04-09T13:05:16Z

@idnovic The tunnel setting needs to be part of the ssh section!
Also, if you are on wifi, 10.124.0.15 is not the address you want to be using...

idnovic · 2021-04-09T13:30:24Z

@idnovic The tunnel setting needs to be part of the ssh section!
Also, if you are on wifi, 10.124.0.15 is not the address you want to be using...

Thank you. It does work now.
I had the configuration wrong.

Can you add a configuration checker?
The syntax was correct but I had one option at the wrong location.

About the ip address. We have a large network. And it is part of the private ip address space.

stheid · 2021-04-09T21:15:45Z

a config checker would be a very interesting idea. i would be very interested in programming something like that i am just currently a bit out with the codebase...

Perhaps one could create a yaml based schema file that could be used to validate the config.

bordaigorl · 2021-04-09T21:59:57Z

I think the easiest and most useful feature missing for the config is a settings dialog...
The UI would be easy to set up; the thing that may require refactoring is applying the changes to the config on the fly.
PRs in this direction would be welcome.
The first thing I would do is create an object encapsulating the config, maybe with signals to notify of changes.

stheid · 2021-04-10T09:57:11Z

yeah, a settings UI would be best, however thats clearly more involved. FYI: https://python-jsonschema.readthedocs.io/en/stable/

Kami · 2021-04-16T17:46:25Z

Yeah, something like json schema + additionalProperties: false would probably work fine.

In case we only want to support recent Python 3 version, we could also use something like pydantic (https://pydantic-docs.helpmanual.io/) which utilizes native type hints syntax.

Prompting for the passphrase can only be done from main thread!

… rotation

do not garbage collect cloned frames and create them with the correct rotation

Add dockerfile and run script

bordaigorl and others added 30 commits January 29, 2021 21:50

Don't resize at autoresize if fullscreen

5e05cd7

Forwarding key/pointer events

6145d3e

- Refactoring to allow calling protocol methods in fbworker - Adding Pause/Resume - Forwarding keys and pointer events (shift -> pen, clicks -> touch)

Better handling of disconnection

74de306

Handle key input emulation via shortcuts

c38c44d

Refactor actions and shortcuts

12e456c

Proper handling of reactor thread

254d5f5

New auto orientation option

3811abd

- "auto_on_load" detects orientation once at startup - "auto" detects orientation at each update Todo: make detection more reliable

More principled detection of orientation

1327759

Properly saving and merging known_hosts

85e42d6

Render hint flags

5cb7288

Show pen delay

01165fe

Remove frame around QGraphicsView

939d1b0

On some platforms there's an unwanted border otherwise.

Don't log raw password to the console.

88d998b

Add support for specifing password for password protected key file in

311c8b8

the config using ssh.password config option.

Allow app to be stopped gracefully using CTRL+C when QT app main loop is

4b5041b

running.

Use larger default timeout.

3b3dcec

Update some log statements, add a comment on slow host loading.

c26efcd

Add support for using an SSH tunnel.

ba98c0e

This should be preffered approach when connecting to remarkable over (W)LAN for security reasons.

Display connecting screen until we successfully connect.

64d14ba

Fix typo.

b5db56f

Prefix log messages with a timestamp and level.

825be6a

Improve logging.

4302325

Enable SSH tunnel compression since it seems to result in slightly

9174139

better performance.

Update comment.

3a84027

Use custom made connecting image to avoid potential copyright /

0f796e2

trademark issues.

Update readme.

ea5a0cd

Merge branch 'devel' of https://github.com/bordaigorl/rmview into var…

e9c2dfa

…ious_changes

Log a warning message if config file is readable by others.

9776b60

Fix merge conflict resolution.

5001b6f

bordaigorl and others added 12 commits April 17, 2021 00:56

Move key loading to init of connection worker

853f25a

Prompting for the passphrase can only be done from main thread!

Minor cleanup

34a3d92

Wrong field name known_hosts

314e822

Add dockerfile and run script

6cc9432

Disable forward_mouse_events by default, add docs

178c806

Correcting warning message (fixes #73)

1133189

Pinch to Zoom

f2fd104

do not garbage collect cloned frames and create them with the correct…

462d7de

… rotation

Garbage collect cloned frames on close

bc7882f

Merge pull request #79 from vale981/devel

1cc4ddb

do not garbage collect cloned frames and create them with the correct rotation

Merge pull request #71 from larsblumberg/add-dockerfile

096e372

Add dockerfile and run script

Line length in setup.cfg (prepare for linting)

4772073

This was referenced Jul 21, 2021

Not working w/ reMarkable OS 2.8.0.98 -- libcrypto.so.1.0.2 not found #82

Closed

Testing new server on RM2 #88

Closed

bordaigorl added 6 commits September 6, 2021 17:06

Refactoring: move pen tracker out of workers

5e70df8

Detect tablet/software version on connection

02f5947

Software version timestamps

bfd9a98

Make RFB client compatible with ScreenShare (thanks to @ddvk #87)

1198a21

Add compatibility with ScreenShare (fixes #86, #87)

68456c3

Some docs

23f56fe

bordaigorl merged commit 4d80057 into vnc Sep 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Version 2.2#63

Version 2.2#63
bordaigorl merged 65 commits into
vncfrom
devel

bordaigorl commented Apr 8, 2021 •

edited

Loading

Uh oh!

bordaigorl commented Apr 8, 2021 •

edited

Loading

Uh oh!

idnovic commented Apr 9, 2021 •

edited

Loading

Uh oh!

idnovic commented Apr 9, 2021

Uh oh!

bordaigorl commented Apr 9, 2021 •

edited

Loading

Uh oh!

idnovic commented Apr 9, 2021

Uh oh!

stheid commented Apr 9, 2021

Uh oh!

bordaigorl commented Apr 9, 2021

Uh oh!

stheid commented Apr 10, 2021

Uh oh!

Kami commented Apr 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

bordaigorl commented Apr 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bordaigorl commented Apr 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

idnovic commented Apr 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

idnovic commented Apr 9, 2021

Uh oh!

bordaigorl commented Apr 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

idnovic commented Apr 9, 2021

Uh oh!

stheid commented Apr 9, 2021

Uh oh!

bordaigorl commented Apr 9, 2021

Uh oh!

stheid commented Apr 10, 2021

Uh oh!

Kami commented Apr 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bordaigorl commented Apr 8, 2021 •

edited

Loading

bordaigorl commented Apr 8, 2021 •

edited

Loading

idnovic commented Apr 9, 2021 •

edited

Loading

bordaigorl commented Apr 9, 2021 •

edited

Loading