You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks a lot, very good catch !
I'm going to push a fix on main to solve the issue with src-jvm2 but we should definitely update it as well (I'm almost done with the mill changes)
@limansky I believe we made a typo when upgrading to Scala 3, by naming the folder src-jvm2 instead of src-jvm-2 those files were indeed not used anymore.
This is now fixed, but it means that we will have to migrate them to Pekko as well.
The easiest way I found to run a bunch of example is to run them directly in mill:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #358
I've found that
examples/src-jvm2folder is not used in compilation, so I didn't changed examples there.