New methods for question and template testing#15
Open
KarlisJ wants to merge 15 commits intobotman:masterfrom
Open
New methods for question and template testing#15KarlisJ wants to merge 15 commits intobotman:masterfrom
KarlisJ wants to merge 15 commits intobotman:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
============================================
+ Coverage 61.81% 68.27% +6.46%
- Complexity 73 141 +68
============================================
Files 7 12 +5
Lines 254 457 +203
============================================
+ Hits 157 312 +155
- Misses 97 145 +48
Continue to review full report at Codecov.
|
Contributor
Author
|
For some reason can not get StyleCI to pass. It want to remove and add the same line |
Contributor
|
This is a great idea! Can this please get merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added methods to fully test questions and FB templates
There are new tests written to see almost all new methods in action.
There will be a conflict with
assertTemplatemethod. Currently it expects second (optional) parameter to be boolean$strictbut in this PR it expects a closure. Old "strict" comparison was bad call because it actually does not differ fromassertRaw.