Open
Conversation
Author
|
@mpociot , could you plz pay some attention to PRs? |
|
Great, I'll add it to here https://www.npmjs.com/package/botman-extended-web-widget |
EranGrin
added a commit
to EranGrin/botman-extended-web-widget
that referenced
this pull request
Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I am trying to start conversation with user from widgetOpened event, like this:
I see in my cache conversation duplicates (and in UI too):
The first hash is constantly equals
sha1(""). The reason is widgetOpened event, which raise first instance of conversation, has no binding to any user.With my fix all seems to work ok.