added sandbox attribute with same origin and allow scripts#53
Open
AKApumkin wants to merge 1 commit intobotman:masterfrom
Open
added sandbox attribute with same origin and allow scripts#53AKApumkin wants to merge 1 commit intobotman:masterfrom
AKApumkin wants to merge 1 commit intobotman:masterfrom
Conversation
…e security and pass pen testing scans
|
Quite interesting, I'll consider this feat for https://www.npmjs.com/package/botman-extended-web-widget |
|
I have added a configuration props to pass any sandbox attribute to the iframe on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the sandbox attribute with specified parameters can help increase security by not allowing outside script injection through Iframes, also it will mean that it passes most security scans as iframes without the sandbox attribute always get flagged.