Revert "Merge pull request #328 from rpkelly/sbom-build-dir"#337
Merged
vigh-m merged 2 commits intobottlerocket-os:developfrom Mar 5, 2026
Merged
Revert "Merge pull request #328 from rpkelly/sbom-build-dir"#337vigh-m merged 2 commits intobottlerocket-os:developfrom
vigh-m merged 2 commits intobottlerocket-os:developfrom
Conversation
vigh-m
previously approved these changes
Mar 5, 2026
vigh-m
force-pushed
the
revert-sbom-build-dir
branch
from
eb65356 to
a7b7d14
Compare
Contributor
|
⬆️ Updated to revert the commits from #328 instead of the merge commit |
vigh-m
dismissed
their stale review
I updated the change and shouldn't approve my own change
yeazelm
approved these changes
Mar 5, 2026
piyush-jena
approved these changes
Mar 5, 2026
arnaldo2792
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit causes a conflict with the metatdata package generated by twoliter. Since this commit attempts to allow more types of packages to generate SBOMs, the metadata packages now attempts to generate an sbom. Unfortunately, it already has a subpackage called sbom.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.