fix(common): fix Flow errors in nav-button component #3976
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Author
|
Closing this PR as requested. The Flow fixes will be incorporated into the original PR #3966 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Flow errors in nav-button component
This PR fixes Flow errors that were occurring when using the TypeScript-converted nav-button component in Flow files.
Changes
BackButton.js.flowto accept bothLocationandstringfor thetopropNavButton.js.flowto make thehashproperty optional in theLocationtype.js.flowfiles for components that use the nav-button component to maintain Flow type compatibilityRelated PR
This PR is related to #3966, which converts the nav-button component to TypeScript.
Link to Devin run: https://app.devin.ai/sessions/11a19ecf27cd4dbf856d59a802788239