-
Notifications
You must be signed in to change notification settings - Fork 344
feat(metadata-view): update blueprint web version #4288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughBumped Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant CascadePolicy as CascadePolicy Component
participant Assets as blueprint-web-assets
note right of Assets #d3f3e6: Export names changed
CascadePolicy->>Assets: import BoxAiAdvancedLogo24, BoxAiLogo24
CascadePolicy->>CascadePolicy: render UI with Logo icons
note over CascadePolicy,Assets #f7f3d9: Visual substitution only\n(control flow unchanged)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
package.json (1)
127-300: Version bump targets a ghost release, fool!You’re pointing both dev and peer dependencies at
@box/blueprint-web-assets@^4.68.6, but that build ain’t on the public registry yet—the latest published is 4.66.4. Yarn install will choke, and the whole crew goes down. Either publish 4.68.6 to the configured registry or stick to a released version. I pity the fool who merges with an unreachable package. Based on learningsApply this diff to revert to the latest available release:
- "@box/blueprint-web-assets": "^4.68.6", + "@box/blueprint-web-assets": "^4.66.4",- "@box/blueprint-web-assets": "^4.68.6", + "@box/blueprint-web-assets": "^4.66.4",
🧹 Nitpick comments (1)
flow-typed/npm/@box/blueprint-web-assets_vx.x.x.js (1)
10-11: Flow stub stuck in the wrong hood, sucka!These new exports still live under the Medium module in the stub, but the real code now grabs them from
icons/Logo. Get the definitions moved so Flow stops needing a fixme and future imports don’t blow up. I pity the fool who leaves Flow stubs out of sync.declare module '@box/blueprint-web-assets/icons/Medium' { declare export var InformationCircle: React$ComponentType<any>; declare export var CheckmarkCircle: React$ComponentType<any>; declare export var AlertCircle: React$ComponentType<any>; declare export var AlertTriangle: React$ComponentType<any>; declare export var XMark: React$ComponentType<any>; - declare export var BoxAiAdvancedLogo24: React$ComponentType<any>; - declare export var BoxAiLogo24: React$ComponentType<any>; } declare module '@box/blueprint-web-assets/icons/Logo' { declare export var BoxLogo: React$ComponentType<any>; declare export var BoxAiLogo: React$ComponentType<any>; + declare export var BoxAiAdvancedLogo24: React$ComponentType<any>; + declare export var BoxAiLogo24: React$ComponentType<any>; }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (3)
flow-typed/npm/@box/blueprint-web-assets_vx.x.x.js(1 hunks)package.json(2 hunks)src/features/metadata-instance-editor/CascadePolicy.js(3 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: tjuanitas
PR: box/box-ui-elements#4224
File: package.json:296-297
Timestamp: 2025-08-12T18:04:17.698Z
Learning: In the box-ui-elements project, the team is comfortable with raising peerDependency minimum versions when upgrading blueprint-web packages, even if it's a breaking change for consumers.
📚 Learning: 2025-05-14T17:46:25.370Z
Learnt from: ahorowitz123
PR: box/box-ui-elements#4102
File: src/features/metadata-instance-editor/Instance.js:647-649
Timestamp: 2025-05-14T17:46:25.370Z
Learning: In the metadata-instance-editor component, `isExistingAIExtractionCascadePolicy` specifically checks if the cascade policy fetched from the backend has AI folder extraction enabled, using props rather than state to reflect the original server-side configuration rather than current UI state.
Applied to files:
src/features/metadata-instance-editor/CascadePolicy.js
📚 Learning: 2025-07-11T14:43:02.677Z
Learnt from: jpan-box
PR: box/box-ui-elements#4166
File: src/elements/content-sidebar/SidebarNav.js:126-126
Timestamp: 2025-07-11T14:43:02.677Z
Learning: In the box-ui-elements repository, there's a file-type-based pattern for internationalization: TypeScript files (.tsx) predominantly use the modern useIntl hook (41 vs 15 files), while JavaScript files (.js) predominantly use the legacy injectIntl HOC (64 vs 5 files). New TypeScript components should use useIntl, while existing JavaScript components typically continue using injectIntl for consistency.
Applied to files:
src/features/metadata-instance-editor/CascadePolicy.js
📚 Learning: 2025-08-12T18:04:17.698Z
Learnt from: tjuanitas
PR: box/box-ui-elements#4224
File: package.json:296-297
Timestamp: 2025-08-12T18:04:17.698Z
Learning: In the box-ui-elements project, the team is comfortable with raising peerDependency minimum versions when upgrading blueprint-web packages, even if it's a breaking change for consumers.
Applied to files:
package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: lint_test_build
- GitHub Check: Summary
🔇 Additional comments (3)
src/features/metadata-instance-editor/CascadePolicy.js (3)
9-9: Smooth upgrade to the logo setLooks tight with the new Blueprint drop, fool—import path matches the renamed exports, so we stay outta trouble.
76-81: Custom icon keeps the blingHooking up
BoxAiAdvancedLogo24keeps that enhanced agent shining without code churn—no issues from this pitier of fools.
177-177: AI toggle icon stays crispDropping in
BoxAiLogo24scales clean at 16px, so the UI stays sharp—no fooling around needed.
jfox-box
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #4294. You may have to fix your CI before adding the pull request to the queue again. |
Summary by CodeRabbit
Chores
Style