Add partner base names to agreement alerts by pylipp · Pull Request #2642 · boxwise/boxtribute

pylipp · 2026-03-25T15:14:30Z

sentry · 2026-03-25T15:19:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.28%. Comparing base (181eeb4) to head (797e12f).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2642      +/-   ##
==========================================
- Coverage   78.28%   78.28%   -0.01%     
==========================================
  Files         281      281              
  Lines       20603    20609       +6     
  Branches     2103     2105       +2     
==========================================
+ Hits        16129    16133       +4     
- Misses       4426     4428       +2     
  Partials       48       48

Flag	Coverage Δ
backend	`99.50% <ø> (ø)`
frontend	`70.55% <ø> (-0.01%)`	⬇️
sharedComponents	`68.72% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pylipp · 2026-03-30T07:55:08Z

@aerinsol review appreciated :)
For the last popup I was considering to but the base information at the end, like:

BoxCare has a transfer request OPEN with you with the following details:

Created By: Jane Doe on ...
From BoxCare
Involved bases: Samos, Athens

X Reject    V Accept

aerinsol

@pylipp there is some inconsistency with how the request version (final screencap of the four) is bolding names and bases. I'd like that to be resolved before committing. My suggestions:

Bold the status (or OPEN in this case)
Make sure there's a colon : after From

And yes, I like the separate 'involved bases' section you have - clearer and faster to read.

Copilot

Pull request overview

Adds partner base names to the transfer agreement overlay dialogs so users can see which bases are involved when reviewing/accepting/terminating agreements.

Changes:

Extend transfer-agreement table row data with partnerBases.
Populate partnerBases from GraphQL sourceBases / targetBases (currently only for bidirectional agreements).
Render partner base names in the agreement overlay text for several agreement states.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
`front/src/views/Transfers/TransferAgreementOverview/TransferAgreementOverviewView.tsx`	Adds `partnerBases` to transformed table rows and fills it from `sourceBases`/`targetBases` for bidirectional agreements.
`front/src/views/Transfers/TransferAgreementOverview/components/TransferAgreementOverlay.tsx`	Displays partner base names in the overlay dialog copy across multiple agreement states.

Copilot · 2026-03-30T20:35:48Z

            agreementRow.partnerOrg = element.targetOrganisation.name;
+            agreementRow.partnerBases = element.targetBases?.map((base) => base.name) ?? [];
          } else if (currentOrgId === targetOrgId) {
            agreementRow.partnerOrg = element.sourceOrganisation.name;
+            agreementRow.partnerBases = element.sourceBases?.map((base) => base.name) ?? [];


partnerBases is only populated for Bidirectional agreements. For SendingTo / ReceivingFrom agreements the field stays as the default empty array, so the overlay will display no base names even though sourceBases/targetBases are available in the fragment. Populate partnerBases in the non-bidirectional branches as well (use targetBases when the partner is the target org, and sourceBases when the partner is the source org).

Copilot · 2026-03-30T20:35:48Z

          Created By: <Text as="b">{data.requestedBy}</Text> on{" "}
          <Text as="b">{data.requestedOn}</Text>
          <br />
-          From <Text as="b">{data.partnerOrg}</Text>
+          Involved base(s): {data.partnerBases.join(", ")}
        </chakra.span>


data.partnerBases.join(", ") renders an empty string when partnerBases is empty/undefined (e.g., agreements can legitimately have no active bases). Consider rendering a fallback like “All bases”/“—”, or conditionally hiding the line when there are no base names to show.

Copilot · 2026-03-30T20:35:49Z

+          Your transfer agreement with {data.partnerOrg} (involved base(s):{" "}
+          {data.partnerBases.join(", ")}) is currently <Text as="b">ACCEPTED</Text>.
        </chakra.span>


If partnerBases is empty, this parenthesized “(involved base(s): …)” renders as (involved base(s): ), which looks broken. Use a conditional/fallback string to avoid showing empty parentheses.

Copilot · 2026-03-30T20:35:49Z

+          Your transfer agreement with {data.partnerOrg} (involved base(s):{" "}
+          {data.partnerBases.join(", ")}) is currently <Text as="b">DECLINED</Text>.
        </chakra.span>


If partnerBases is empty, this parenthesized “(involved base(s): …)” renders as (involved base(s): ), which looks broken. Use a conditional/fallback string to avoid showing empty parentheses.

Copilot · 2026-03-30T20:35:49Z

+          Your transfer agreement with {data.partnerOrg} (involved base(s):{" "}
+          {data.partnerBases.join(", ")}) is currently <Text as="b">ENDED</Text>.
        </chakra.span>


If partnerBases is empty, this parenthesized “(involved base(s): …)” renders as (involved base(s): ), which looks broken. Use a conditional/fallback string to avoid showing empty parentheses.

pylipp requested a review from aerinsol March 25, 2026 15:16

pylipp force-pushed the base-names-in-agreemnet-alerts branch from 6a750af to 8f62101 Compare March 25, 2026 16:18

aerinsol requested changes Mar 30, 2026

View reviewed changes

pylipp added 3 commits March 30, 2026 15:40

Add partner base names to agreement alerts

367cd5e

fix-tsc

4418b96

update-alert-structure

797e12f

pylipp force-pushed the base-names-in-agreemnet-alerts branch from 8f62101 to 797e12f Compare March 30, 2026 20:25

pylipp requested a review from Copilot March 30, 2026 20:32

Copilot started reviewing on behalf of pylipp March 30, 2026 20:33 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

pylipp merged commit 201aa89 into master Mar 30, 2026
18 checks passed

pylipp deleted the base-names-in-agreemnet-alerts branch March 30, 2026 20:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add partner base names to agreement alerts#2642

Add partner base names to agreement alerts#2642
pylipp merged 3 commits intomasterfrom
base-names-in-agreemnet-alerts

pylipp commented Mar 25, 2026 •

edited

Loading

Uh oh!

sentry Bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

pylipp commented Mar 30, 2026

Uh oh!

aerinsol left a comment •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Copilot AI Mar 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

pylipp commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sentry Bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pylipp commented Mar 30, 2026

Uh oh!

aerinsol left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pylipp commented Mar 25, 2026 •

edited

Loading

sentry Bot commented Mar 25, 2026 •

edited

Loading

aerinsol left a comment •

edited

Loading