Open
Conversation
Code as it was did not work for me. I went through and cleaned up a few areas. I removed the brackets ({}) from the for loop as that was broken. I also updated some variables with double-quotes (") to prevent globbing/splitting. I also added a check for greater than 1 entry in each array to prevent a stray comma.
Some "crypto users" are not actually users but service tokens, such as the bootstraptoken. If it doesn't have a user name, don't check its admin status and potentially add a "blank" username to the user arrays.
Author
|
I added another if statement to filter out CryptoUsers that aren't actually users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code as it was did not work for me. I went through and cleaned up a few areas. I removed the brackets ({}) from the for loop as that was broken. I also updated some variables with double-quotes (") to prevent globbing/splitting. I also added a check for greater than 1 entry in each array to prevent a stray comma.