update doc string to match actual code behaviour.#2
Open
c0ffee2code wants to merge 2 commits intobradcar:mainfrom
Open
update doc string to match actual code behaviour.#2c0ffee2code wants to merge 2 commits intobradcar:mainfrom
c0ffee2code wants to merge 2 commits intobradcar:mainfrom
Conversation
1. judging based on euler_conversion method the order inside val is: qr, qi, qj and qk 2. euler_conversion method returns 3-tuple with yaw, pitch, roll only.
Owner
|
Thanks! I'm Traveling for a few days, but I will take a look soon. Really appreciate the work! |
Author
|
I can also offer an implementation of gyro integrated rotation vector. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
First of all thank you for such comprehensive and well documented driver implementation !
I took the liberty to correct doc strings which caught my eye as they diverge from actual code behaviour.