Skip to content

Comments

update doc string to match actual code behaviour.#2

Open
c0ffee2code wants to merge 2 commits intobradcar:mainfrom
c0ffee2code:main
Open

update doc string to match actual code behaviour.#2
c0ffee2code wants to merge 2 commits intobradcar:mainfrom
c0ffee2code:main

Conversation

@c0ffee2code
Copy link

@c0ffee2code c0ffee2code commented Feb 7, 2026

Hello,
First of all thank you for such comprehensive and well documented driver implementation !
I took the liberty to correct doc strings which caught my eye as they diverge from actual code behaviour.

  1. judging based on euler_conversion method the order inside val is: qr, qi, qj and qk
  2. euler_conversion method returns 3-tuple with yaw, pitch, roll only.

Grigorii Fadeev and others added 2 commits February 7, 2026 11:40
1. judging based on euler_conversion method the order inside val is: qr, qi, qj and qk
2. euler_conversion method returns 3-tuple with yaw, pitch, roll only.
@bradcar
Copy link
Owner

bradcar commented Feb 15, 2026

Thanks! I'm Traveling for a few days, but I will take a look soon.

Really appreciate the work!

@c0ffee2code
Copy link
Author

c0ffee2code commented Feb 15, 2026

I can also offer an implementation of gyro integrated rotation vector.
It is primarily done by Claude Code based on your driver + the Hilcrest specs under my guidance + I manually tested it quite heavily as part of my pet project.
If such contribution (AI + human brain and hands) is okey i would be more than happy to submit another PR. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants