Merged
Conversation
Collaborator
|
Smart idea - the zero-dependency node:* approach is the right call for CI scripts. Few notes:
No rush on this one, but the direction is good. |
Collaborator
Author
📁 Files in this PR (11)
11 files — 1 workflow, 5 scripts, 4 tests, 1 test helper. |
diberry
force-pushed
the
squad/repo-health-initiative
branch
from
2fcc8f2 to
95657f1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a “repo health” CI workflow plus four Node-only scripts (and Vitest coverage) to enforce/bootstrap-check dependencies and surface architectural/security signals as PR comments.
Changes:
- Introduces health-check scripts for bootstrap dependency enforcement, .squad/ leakage detection, architectural review, and security review.
- Adds a
pull_request_targetworkflow to run these checks on PRs targetingdev, including PR-comment upserts via a shared comment helper. - Adds Vitest integration/unit tests plus shared test helpers for the new scripts.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/squad-repo-health.yml |
New PR-target workflow to run health checks and post PR comments. |
scripts/check-bootstrap-deps.mjs |
Blocking gate to ensure protected bootstrap files only use built-in/relative imports. |
scripts/check-squad-leakage.mjs |
Informational detector for .squad/ files in PR diffs. |
scripts/architectural-review.mjs |
Informational checks for module boundaries, template sync signals, sweeping refactors, deletions. |
scripts/security-review.mjs |
Informational checks for common risky patterns in diffs/workflows/deps. |
scripts/repo-health-comment.mjs |
Shared PR comment upsert utility (marker-based). |
test/scripts/helpers.ts |
Shared subprocess + JSON-extraction helpers for script tests. |
test/scripts/check-bootstrap-deps.test.ts |
Unit/integration tests for bootstrap dependency checker. |
test/scripts/check-squad-leakage.test.ts |
Integration tests for .squad/ leakage checker. |
test/scripts/architectural-review.test.ts |
Unit/integration tests for architectural review script. |
test/scripts/security-review.test.ts |
Unit/integration tests for security review script. |
Contributor
🛫 PR Readiness Check
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 2 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | No source files changed — changeset not required |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | All 6 Copilot thread(s) resolved |
| ❌ | CI passing | 4 check(s) still running |
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
diberry
force-pushed
the
squad/repo-health-initiative
branch
2 times, most recently
from
b987467 to
3626ba0
Compare
Collaborator
Author
|
Closing and reopening to trigger PR readiness workflow (workflow was added to dev after this PR was opened). |
diberry
force-pushed
the
squad/repo-health-initiative
branch
from
3626ba0 to
6b926d0
Compare
Add repo health check workflows and scripts: dependency audit, security scanning, lint config validation, and PR comment reporting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
diberry
force-pushed
the
squad/repo-health-initiative
branch
from
6b926d0 to
4869017
Compare
tamirdresher
approved these changes
Apr 4, 2026
Collaborator
tamirdresher
left a comment
tamirdresher
left a comment
There was a problem hiding this comment.
LGTM. Well-structured CI with modular scripts, 900+ LOC of tests, proper pull_request_target security model. 4 concurrent checks are clean.
Collaborator
Author
|
Files in this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 4 automated repo health scripts and a GitHub Actions workflow:
ode:*\ imports
Workflow: \squad-repo-health.yml\ runs all 4 on PRs targeting dev with \pull_request_target\ for fork write token support.
All scripts use only
ode:*\ built-ins (no npm install needed). Each informational check posts a PR comment with HTML markers for upsert.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com