fix: ignore outdated Copilot review threads in PR readiness check#780
Merged
fix: ignore outdated Copilot review threads in PR readiness check#780
Conversation
Contributor
🛫 PR Readiness Check
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 3 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | No source files changed — changeset not required |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | All 2 Copilot thread(s) resolved |
| ❌ | CI passing | 11 check(s) still running |
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the PR readiness script to avoid blocking merges due to outdated Copilot review threads (threads invalidated by subsequent pushes), by fetching isOutdated from GitHub GraphQL and excluding those threads from the “unresolved Copilot threads” calculation.
Changes:
- Extend the GraphQL
reviewThreadsquery to includeisOutdated. - Update
checkCopilotThreadsto ignore outdated threads when determining unresolved Copilot threads. - Update the success detail message to indicate how many outdated threads were skipped.
diberry
force-pushed
the
squad/fix-outdated-thread-check
branch
2 times, most recently
from
f764dee to
640a579
Compare
- Add isOutdated to GraphQL reviewThreads query - Filter out outdated threads when computing unresolved count - Improve success message to distinguish resolved vs outdated threads - Add test cases for outdated thread filtering (74 tests pass) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
diberry
force-pushed
the
squad/fix-outdated-thread-check
branch
from
640a579 to
d721b20
Compare
tamirdresher
approved these changes
Apr 4, 2026
Collaborator
tamirdresher
left a comment
tamirdresher
left a comment
There was a problem hiding this comment.
LGTM. Targeted fix — only active unresolved threads block, outdated ones are correctly excluded. 3 good test cases.
Collaborator
Author
|
Files in this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outdated threads (where the code was changed by a subsequent push) were incorrectly counted as unresolved, blocking merge even after the issues were addressed.
Changes:
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com