feat(sdk,cli): built-in fact-checker agent role (#789)#795
Merged
tamirdresher merged 2 commits intodevfrom Apr 4, 2026
Merged
Conversation
Contributor
🛫 PR Readiness Check
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 2 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | Changeset file found |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ❌ | CI passing | 15 check(s) still running |
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
Contributor
🏗️ Architectural Review
Automated architectural review — informational only. |
- New fact-checker role in engineering catalog (🔍, quality category) - Charter template with verification methodology and confidence ratings - Added to AGENT_TEMPLATES for init scaffolding - Template manifest entry for init/upgrade distribution - Routing patterns: fact-check, verify, validate, audit, hallucination - 8 new tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- BASE_ROLES count: exact 20 → at least 20 - listRoles() count: exact 20 → at least 20 - Attribution test: accept any truthy attribution (not just agency-agents) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tamirdresher
force-pushed
the
squad/789-fact-checker-agent
branch
from
0caf110 to
1392ff2
Compare
Contributor
🟡 Impact Analysis — PR #795Risk tier: 🟡 MEDIUM 📊 Summary
🎯 Risk Factors
📦 Modules Affectedroot (1 file)
squad-cli (2 files)
squad-sdk (2 files)
tests (2 files)
This report is generated automatically for every PR. See #733 for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
fact-checkeras a built-in agent role in the engineering role catalog, with a charter template and routing patterns for verification and hallucination detection.Why
No agent currently validates output quality before delivery. A Haiku model fabricated 38+ family details in one user's research. Teams need a verification gate. Closes #789
How
fact-checkerrole incatalog-engineering.ts(emoji: 🔍, category: quality)templates/fact-checker-charter.mdwith verification methodology and confidence ratingsAGENT_TEMPLATESfor init scaffoldingTesting
npm run buildpassesnpm testpasses (8 new tests + 3 updated existing tests)Docs
Exports
N/A (role catalog is internal, accessed via
getRoleById)Breaking Changes
None — additive only. Existing role tests updated to use
>=instead of exact counts.Waivers
None