fix(cli): warn when squad watch receives unused message args (#703)#858
Closed
fix(cli): warn when squad watch receives unused message args (#703)#858
Conversation
Contributor
🛫 PR Readiness Check
|
| Status | Check | Details |
|---|---|---|
| ✅ | Single commit | 1 commit — clean history |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | Changeset file found |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | 0 active Copilot thread(s) resolved (3 outdated skipped) |
| ❌ | CI passing | 16 check(s) still running |
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
Contributor
🟡 Impact Analysis — PR #858Risk tier: 🟡 MEDIUM 📊 Summary
🎯 Risk Factors
📦 Modules Affecteddocs (2 files)
root (1 file)
squad-cli (1 file)
This report is generated automatically for every PR. See #733 for details. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the squad watch / squad triage UX by warning when users pass extra positional arguments (which are not used by watch mode), and updates docs/changelog to clarify that watch is a polling loop rather than a message router.
Changes:
- Always warn (not just in
--verbose) whensquad watch/triagereceives unused positional args. - Document the behavior in the CLI reference and Ralph/watch docs.
- Add changelog + changeset entries for the CLI change.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/squad-cli/src/cli-entry.ts | Warns when positional args are provided to watch/triage instead of silently ignoring them. |
| docs/src/content/docs/reference/cli.md | Adds a note in the CLI commands table clarifying extra args are ignored. |
| docs/src/content/docs/features/ralph.md | Adds a cautionary callout explaining watch mode doesn’t route agent messages. |
| CHANGELOG.md | Adds an Unreleased changelog entry describing the new warning + doc clarification. |
| .changeset/watch-message-warning.md | Adds a patch changeset for @bradygaster/squad-cli. |
b3d8531 to
8212d04
Compare
Detects extra positional args passed to squad watch and prints a clear warning instead of silently ignoring them. Users who expect routing get guidance to use an interactive session. Closes #703 Co-authored-by: tamirdresher <tamirdresher@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
8212d04 to
85dc7c8
Compare
Collaborator
Author
|
Closing — superseded by #859 which covers the same cli-entry.ts changes comprehensively. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Detects extra positional args passed to
squad watchand prints a clear warning instead of silently ignoring them.Why
Users expect
squad watch --interval 5 "Nick, Run scheduled tasks"to route the message to agent Nick on each poll cycle. But watch mode only runs Ralph polling loop — the quoted message is silently dropped. This caused confusion (reported by community user).How
Makes the existing positional-arg detection (previously verbose-only) always warn with a clear UX message:
Files Changed
packages/squad-cli/src/cli-entry.ts— warning always shown (was verbose-only)CHANGELOG.md— changelog entrydocs/src/content/docs/features/ralph.md— caution admonitiondocs/src/content/docs/reference/cli.md— CLI reference note.changeset/watch-message-warning.md— changesetCloses #703
Based on PR #704 by @tamirdresher
Co-authored-by: tamirdresher
Co-authored-by: Copilot