feat: PR lifecycle skill + readiness check expansion (9 → 11 checks) by diberry · Pull Request #870 · bradygaster/squad

diberry · 2026-04-05T19:55:28Z

Summary

Adds a comprehensive PR lifecycle skill and expands the readiness check system from 9 to 11 checks.

New skill: .copilot/skills/pr-lifecycle/SKILL.md

Canonical Copilot-agent lifecycle covering 6 phases:

Issue pickup (branch naming, capability check)
Implementation (build/test/lint, staging safety, single commit)
PR creation (target dev, title format, labels)
PR readiness (all 11 checks documented with fix-it instructions)
Post-creation maintenance (review feedback, rebasing, CI)
Merge & cleanup (preconditions, branch deletion, issue close)

Includes gap analysis with 3 recommendations (2 implemented, 1 deferred).

New readiness checks in \scripts/pr-readiness.mjs\

Check	Type	Purpose
\checkIssueLinkage()\	Hard gate	Requires \Closes #N\ (or equivalent) in PR body or commit message
\checkProtectedFiles()\	Informational	Warns when zero-dependency bootstrap files are modified

Both use data already fetched by the orchestrator — zero new API calls.

Tests

90 tests passing (up from 88 before adjusting for new checks). New test coverage:

\checkIssueLinkage: 8 test cases
\checkProtectedFiles: 5 test cases
Run orchestrator tests updated from 9 → 11 check expectations

Deferred

\checkRequiredChecksPresent()\ — would verify expected CI check names ran. Needs team agreement on required check list. Documented in skill's gap analysis section.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

github-actions · 2026-04-05T19:55:39Z

🟡 Impact Analysis — PR #870

Risk tier: 🟡 MEDIUM

📊 Summary

Metric	Count
Files changed	6
Files added	2
Files modified	4
Files deleted	0
Modules touched	4

🎯 Risk Factors

6 files changed (6-20 → MEDIUM)
4 modules touched (2-4 → MEDIUM)

📦 Modules Affected

copilot-config (1 file)

.copilot/skills/pr-lifecycle/SKILL.md

scripts (2 files)

scripts/pr-readiness.mjs
scripts/security-review.mjs

squad-state (2 files)

.squad/agents/procedures/history.md
.squad/decisions/inbox/procedures-pr-lifecycle-skill.md

tests (1 file)

test/pr-readiness.test.ts

This report is generated automatically for every PR. See #733 for details.

github-actions · 2026-04-05T19:55:40Z

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit 3eddbbe

PR Scope: 🔧 Infrastructure

⚠️ 3 item(s) to address before review

Status	Check	Details
✅	Single commit	1 commit — clean history
✅	Not in draft	Ready for review
✅	Branch up to date	Up to date with dev
❌	Copilot review	No Copilot review yet — it may still be processing
✅	Changeset present	No source files changed — changeset not required
✅	Scope clean	⚠️ PR includes 2 .squad/ file(s) — ensure these are intentional
✅	No merge conflicts	No merge conflicts
❌	Copilot threads resolved	1 unresolved Copilot thread(s) — fix and resolve before merging
❌	CI passing	16 check(s) still running

Files Changed (6 files, +756 −5)

File	+/−
`.copilot/skills/pr-lifecycle/SKILL.md`	+537 −0
`.squad/agents/procedures/history.md`	+14 −0
`.squad/decisions/inbox/procedures-pr-lifecycle-skill.md`	+37 −0
`scripts/pr-readiness.mjs`	+57 −0
`scripts/security-review.mjs`	+2 −0
`test/pr-readiness.test.ts`	+109 −5

Total: +756 −5

This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

github-actions · 2026-04-05T19:55:41Z

⚠️ Squad File Leakage Detected

The following .squad/ files were modified in this PR:

.squad/agents/procedures/history.md
.squad/decisions/inbox/procedures-pr-lifecycle-skill.md

These files affect team routing, agent charters, and decisions.
If intentional, ensure approval from the team lead.

Copilot

Pull request overview

Adds a new Copilot skill documenting the end-to-end PR lifecycle and extends the PR readiness orchestrator from 9 → 11 checks by introducing issue-linkage enforcement and a protected-bootstrap-files warning.

Changes:

Added checkIssueLinkage() (hard gate) and checkProtectedFiles() (informational) to scripts/pr-readiness.mjs, plus exported PROTECTED_FILES.
Updated run() orchestration and unit tests to expect and validate 11 readiness checks.
Introduced a new .copilot/skills/pr-lifecycle/SKILL.md skill and recorded the decision/history entries for the change.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`scripts/pr-readiness.mjs`	Adds 2 new check functions and wires them into the readiness run (11 total checks).
`test/pr-readiness.test.ts`	Adds/updates tests for the 2 new checks and updates run expectations from 9 → 11.
`.copilot/skills/pr-lifecycle/SKILL.md`	New “PR lifecycle” skill/runbook intended to be canonical for agents.
`.squad/decisions/inbox/procedures-pr-lifecycle-skill.md`	New decision record capturing the skill + readiness expansion.
`.squad/agents/procedures/history.md`	Adds an agent history entry describing the work and rationale.

Copilot · 2026-04-05T19:58:53Z

+### Phase 4 — PR Readiness
+
+An automated readiness check runs on every push and posts a checklist comment on the PR. All 9 checks must pass before review.
+
+#### Check 1: Single Commit


Phase 4 still says “All 9 checks must pass” and the checklist only documents checks 1–9. Since pr-readiness.mjs now emits 11 checks, add documentation for the new checks (Issue linked + Protected files) and update the wording/count throughout this section.

@copilot apply changes based on this feedback

This was already addressed in commit de965d0. Phase 4 now says "All 11 checks must pass before review" and includes full documentation tables for Check 10 (Issue Linked) and Check 11 (Protected Files informational).

…s expansion, spam protection (PRD #872) Implements PRD #872 — CI/GitHub Actions Performance Optimization. Phase 0+1: Consolidation - Repo Health: 5 jobs → 1 job with sequential steps + GITHUB_STEP_SUMMARY - Policy Gates: 4 jobs → 1 consolidated job (publish-policy kept separate) - PR Readiness: Remove synchronize/reopened from pull_request_target (fix double-trigger) - Concurrency groups added to 10 workflows (true for validation, false for publish) Phase 2: Path Filters - Added code path filter with fail-open semantics to squad-ci.yml - Docs-only PRs skip test, policy-gates, exports-map, samples-build, export-smoke Phase 4: Publish Pipeline - Removed redundant build job from insider-publish (test already builds) PR Readiness Expansion (from #870): - Added checkIssueLinkage() and checkProtectedFiles() checks (9 → 11) - Added PR lifecycle skill (.copilot/skills/pr-lifecycle/SKILL.md) - 13 new tests for readiness checks Comment Spam Protection (from #800): - Added scripts/lock-stale.mjs and scripts/moderate-spam.mjs - Added squad-comment-moderation.yml workflow - Added lock-stale and moderate-spam test suites All safety gates preserved. No product template files modified. Target: ~19 runners per PR push → ~11. Closes #872 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

… 0-2, 4-5) Phase 0+1: Consolidation - Repo Health: 5 jobs to 1 job with sequential steps + GITHUB_STEP_SUMMARY - Policy Gates: 4 jobs to 1 consolidated job (publish-policy kept separate) - PR Readiness: Remove synchronize/reopened from pull_request_target (fix double-trigger) - Concurrency groups added to 10 workflows (true for validation, false for publish) Phase 2: Path Filters - Added code path filter with fail-open semantics to squad-ci.yml - Docs-only PRs skip test, policy-gates, exports-map, samples-build, export-smoke Phase 4: Publish Pipeline - Removed redundant build job from insider-publish (test already builds) PR Readiness Expansion (from #870): - Added checkIssueLinkage() and checkProtectedFiles() checks (9 to 11) - Added PR lifecycle skill (.copilot/skills/pr-lifecycle/SKILL.md) - 13 new tests for readiness checks Security fixes: - Fix script injection in repo-health comment steps (env: block instead of inline interpolation) - Gate policy-gates job to pull_request events only (prevents undefined PR context on push) All safety gates preserved. No product template files modified. Closes #872 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Create comprehensive .copilot/skills/pr-lifecycle/SKILL.md covering the full issue-to-merge lifecycle with all readiness checks documented. Add two new checks to scripts/pr-readiness.mjs: - checkIssueLinkage(): hard gate requiring issue reference in PR body/commits - checkProtectedFiles(): informational warning for zero-dependency bootstrap files Tests updated: 90 passing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

diberry · 2026-04-06T13:06:45Z

Closing — content (readiness checks + PR lifecycle skill) already absorbed into #873. The security-review.mjs skip for SKILL.md is also in #873. Follow-up issue will track adopting waza's ComplianceChecker for proper markdown-aware skill scanning.

Copilot AI review requested due to automatic review settings April 5, 2026 19:55

Copilot started reviewing on behalf of diberry April 5, 2026 19:56 View session

Copilot AI reviewed Apr 5, 2026

View reviewed changes

diberry force-pushed the squad/pr-lifecycle-skill branch 2 times, most recently from 4682699 to de965d0 Compare April 6, 2026 01:27

diberry mentioned this pull request Apr 6, 2026

ci: consolidate workflows, path filters, concurrency (PRD #872 Phases 0-2, 4-5) #873

Merged

7 tasks

Copilot started work on behalf of diberry April 6, 2026 12:42 View session

Copilot finished work on behalf of diberry April 6, 2026 12:44

diberry force-pushed the squad/pr-lifecycle-skill branch from 4d30cd3 to 3eddbbe Compare April 6, 2026 12:50

diberry closed this Apr 6, 2026

diberry mentioned this pull request Apr 6, 2026

feat: Adopt waza ComplianceChecker for skill security scanning #879

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: PR lifecycle skill + readiness check expansion (9 → 11 checks)#870

feat: PR lifecycle skill + readiness check expansion (9 → 11 checks)#870
diberry wants to merge 1 commit intodevfrom
squad/pr-lifecycle-skill

diberry commented Apr 5, 2026

Uh oh!

github-actions bot commented Apr 5, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 5, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Apr 5, 2026

Uh oh!

diberry Apr 6, 2026

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Uh oh!

Uh oh!

diberry commented Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

diberry commented Apr 5, 2026

Summary

New skill: .copilot/skills/pr-lifecycle/SKILL.md

New readiness checks in \scripts/pr-readiness.mjs\

Tests

Deferred

Uh oh!

github-actions bot commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟡 Impact Analysis — PR #870

📊 Summary

🎯 Risk Factors

📦 Modules Affected

Uh oh!

github-actions bot commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛫 PR Readiness Check

⚠️ 3 item(s) to address before review

Files Changed (6 files, +756 −5)

Uh oh!

github-actions bot commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Squad File Leakage Detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

diberry Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

diberry commented Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Apr 5, 2026 •

edited

Loading

github-actions bot commented Apr 5, 2026 •

edited

Loading

github-actions bot commented Apr 5, 2026 •

edited

Loading