-
Notifications
You must be signed in to change notification settings - Fork 60
EPS-1408: Added sticky header notice functionality #1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-candidate
Are you sure you want to change the base?
Conversation
| add_action( 'wp_ajax_hfe_flush_permalink_notice', [ $this, 'hfe_flush_permalink_notice' ] ); | ||
| add_action( 'wp_ajax_nopriv_hfe_flush_permalink_notice', [ $this, 'hfe_flush_permalink_notice' ] ); | ||
|
|
||
| add_action( 'wp_ajax_dismiss_sticky_header_notice', [ $this, 'dismiss_sticky_header_notice' ] ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What: Consider using a more descriptive name for the nonce action instead of 'uae_dismiss_sticky_header_notice'. This will help in identifying the nonce's purpose easily.
Why: Using a descriptive name for your nonce action improves code readability and helps with future maintainability by making it clear what the nonce is intended for.
How: Change the nonce name to something more indicative, for example, 'dismiss_sticky_header_notice_nonce'. This will enhance clarity regarding its purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use hfe specific function name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShubhamGupta05 use hfe specific function name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Description
Main Purpose: This pull request adds functionality for a sticky header promotion notice within the admin interface of the Ultimate Addons for Elementor plugin. It aims to enhance user engagement by encouraging users to upgrade for additional sticky header features.
Key Changes:
dismiss_sticky_header_notice()inclass-hfe-addons-actions.php, including security checks for nonce validation and user capability.class-header-footer-elementor.php.should_show_sticky_header_notice()andrender_sticky_header_notice()to conditionally handle notice display based on user actions, existing headers, and whether the pro version is active.Additional Notes:
Screenshots
Types of changes
How has this been tested?
Checklist: