Final project feedback

[sarahwalters]

Hey Hannah, Gabe, and Sean,

Comments throughout the code & here:

Bugs

• I can't access http://10.26.8.22:8080/?action=stream -- is that one of your IP addresses? do you need to be running a server you're not running right now?
• You've hardcoded a local database address into your ./app.js -- which means that each person who uses your app will see only their own data (and, furthermore, will have to have Mongo installed to use your app). Set up a mlab remote database, maybe?
  • You've got a forum post showing up in your heroku deploy -- is it hardcoded, or is your heroku deploy linked to a remote database somehow?
• I haven't gotten the print form to submit yet -- and I think I'm filling out the form correctly. I'm getting a "Print Form not saved correctly" 500 error. Is it working for you?

Feature/UI requests

• The "Home" tab is always highlighted at the top -- could the highlighting change along with the active tab?
• In the "New Print" workflow, do you need to collect date/time, finish date/time, and duration? wouldn't one of the latter two be enough? (sure enough, you pointed out in ./models/printModel.js that you probably don't need the duration field)
• Could the verification on the print form be more direct? It's hard to figure out what's going wrong when all I get is "Either a required field has been left empty or you have attempted to submit a 6+ hour print without ninja approval"
• What happens if a user inputs date/time in the "wrong" format? Could you use something like a datepicker so you're sure you're getting properly-structured input? (I don't know what happens because I haven't been able to get the form to submit)

Code quality

• You've got some spacing/indentation/semicolon inconsistency -- it's tricky to be consistent about those things when working on a team, but it's also (in my opinion) important for readability & maintainability. I pointed it out inline in a couple places, but not everywhere. A simple linter would help you catch that stuff :)
• Does fullCalendarStuff belong serverside or clientside? I think I see the same files in two places. Also, I might name the fullCalendarStuff directory something like ./lib/fullCalendar if it belongs serverside or ./public/javascript/lib/fullCalendar if it belongs clientside -- if you had other serverside dependencies, they'd go in ./lib/otherDependency; if you had other clientside dependencies, they'd go in ./public/javascript/lib/otherDependency.
• I'm confused about the Angular/jquery mix on the clientside, and you have some namespacing issues (discussed in more detail in the code).

Remember not to merge these pull requests -- take a look at the feedback, feel free to comment if you'd like to discuss anything, and then close the PR.