Use an existing player if present when video changes.#61
Use an existing player if present when video changes.#61alexthewilde wants to merge 3 commits intobrandly:masterfrom
Conversation
There was a problem hiding this comment.
can we do obj.hasOwnProperty(key) instead of the underscore dependency?
|
i haven't pulled this down and tested things out yet, but this looks like the right approach! thanks a lot for the help 🌟 |
There was a problem hiding this comment.
what does this getIframe() check do?
There was a problem hiding this comment.
Thanks for all of your hard work here @brandly @alexthewilde. scope.player.cueVideoById === 'function' doesn't work for me. It causes the check for the preexisting player to fail when a valid player is instantiated. I think you might mean (typeof scope.player.cueVideoById === 'function') here?
There was a problem hiding this comment.
@brandly I believe this method returns the DOM node for the embedded iframe, maybe the intention is to make sure that it exists/is loaded?
There was a problem hiding this comment.
The getiframe function doesn't exists. I guess alex forget this one to include
|
hey, @alexthewilde! take a look at my comments when you get a chance |
4 participants
See original issue #46
Fix adapted from #48