This repository was archived by the owner on May 5, 2024. It is now read-only.
Creating a translation class which enables the usage of translated error messages#70
Conversation
…ror messages - created the \Upload\Translation class - created the folder src/Upload/Language with 2 files: en.php and pt-BR.php - the language files returns an array with messages as key / value - the message keys are the original messages used in the project, so if the user decides to not use the validation class, it won't affect the behavior - added a TranslationTest class - added additional tests to existent test classes - updated the README.md to display usage of the translation class - added aditional methods to use the translation inside existing classes and because the project still gives support to PHP 5.3, trait usage was avoided
Author
|
Brandon, I run the test using PHPUnit and all tests passed here. |
Contributor
|
@ramirovjr the develop branch is about 3 years out of date, it should really be removed. Can you retarget this at master? |
Author
|
Yes, just need to fix the conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decides to not use the validation class, it won't affect the behavior
the project still gives support to PHP 5.3, trait usage was avoided