Fix scriptlet argument parsing for JavaScript expressions #591
+34
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes brave#398 - Allow scriptlet arguments containing JavaScript expressions that start with quoted strings but are not fully quoted. For example: - "test"!==undefined - "value"||something The parser now falls back to comma-separated parsing when it detects an operator after a closing quote, treating the entire expression as a single unquoted argument. Malformed quoted arguments (like unmatched quotes or quotes followed by alphanumeric characters) are still properly rejected. This change increments ADBLOCK_RUST_DAT_VERSION to 4 as it affects which filters are considered valid and thus changes serialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #398 - Allow scriptlet arguments containing JavaScript expressions that start with quoted strings but are not fully quoted. For example:
The parser now falls back to comma-separated parsing when it detects an operator after a closing quote, treating the entire expression as a single unquoted argument. Malformed quoted arguments (like unmatched quotes or quotes followed by alphanumeric characters) are still properly rejected.
This change increments ADBLOCK_RUST_DAT_VERSION to 4 as it affects which filters are considered valid and thus changes serialization.