Skip to content

add sudo validation #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theFong wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add sudo validation #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions v1/image.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,13 @@ func ValidateInstanceImage(ctx context.Context, instance Instance, privateKey st
return err
}

fmt.Printf("Instance image validation passed for %s: architecture=%s, os=%s, home=%s, systemd=%s\n",
instance.CloudID, arch, osVersion, homeDir, systemdStatus)
sudoStatus, err := validateSudoAccess(ctx, sshClient)
if err != nil {
return err
}

fmt.Printf("Instance image validation passed for %s: architecture=%s, os=%s, home=%s, systemd=%s, sudo=%s\n",
instance.CloudID, arch, osVersion, homeDir, systemdStatus, sudoStatus)

return nil
}
Expand Down Expand Up @@ -152,3 +157,15 @@ func validateSystemd(ctx context.Context, sshClient *ssh.Client) (string, error)

return "", fmt.Errorf("expected systemd to be running or degraded, got: %s", systemdStatus)
}

func validateSudoAccess(ctx context.Context, sshClient *ssh.Client) (string, error) {
// Test if sudo is available and can run without a password
// -n flag means non-interactive (no password prompt)
stdout, stderr, err := sshClient.RunCommand(ctx, "sudo -n true")
if err != nil {
return "", fmt.Errorf("failed to verify sudo access: %w, stdout: %s, stderr: %s", err, stdout, stderr)
}

// If the command succeeded, we have passwordless sudo access
return "available", nil
}
Loading