This repository was archived by the owner on Dec 30, 2019. It is now read-only.
Add interface to generic-pool getters#61
Closed
j1banez wants to merge 1 commit intobrianc:masterfrom
j1banez:add-genericpool-getters-interface
Closed
Add interface to generic-pool getters#61j1banez wants to merge 1 commit intobrianc:masterfrom j1banez:add-genericpool-getters-interface
j1banez wants to merge 1 commit intobrianc:masterfrom
j1banez:add-genericpool-getters-interface
Conversation
|
This PR could be part of it: #59 as it does the same, specifically for one flag. |
Owner
|
generic pool has been removed as a dependency, so all the getters are now directly on If you or your company benefit from node-postgres and have the means, please consider supporting my work on Patreon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If one needs to access pool state (total size, available objects and in use objects) it has to access the genericPool getters like this:
While it works it is a bit risky cause
pool.poolis an internalgeneric-pool 2.4.3instance thus we have no control to whengeneric-poolwill be updated and when the api will break, and it will break becausegeneric-pool 3's getters has been renamed.So I suggest with this PR to add
pg-poolgetters that wrapgeneric-poolgetters in order to safely access the pool state,When
pg-poolwill update his version of 'generic-pool' we will just need to update thepg-poolgettersto use the new names of the
generic-poolgetters and it will be transparent with no breaking changes for the users.