Open
Conversation
Author
|
On second thought, I'm not sure this is the right approach, as node-gyp and its 27MiB of dependencies will be transitively present in users' node_modules. It does seem to be the recommended approach by yarn, though. |
Owner
|
Thank you for the PR @sammko. TBH I haven't followed the state of things node-gyp related and I am therefore unaware of changed best practices. Given my lack of additional insight, I would therefore keep this PR open until additional insight (in the form of comments/articles) emerges. I hope you understand. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently
npmhas stopped bundling thenode-gyp-bindirectory (npm/cli#6554). But yarn classic uses this location to find npm's bundled node-gyp. Yarn detects thatevent-loop-statsuses node-gyp in its lifecycle script but does not specify it as a dependency, so it tries to ensure that node-gyp is installed. As it can't find the npm's bundled one, it instead tries to install it globally into its own store (equivalent toyarn global add node-gyp). But this triggers a yarn bug (yarnpkg/yarn#3728), where it doesn't then proceed with the rest of the installation correctly and doesn't generate a yarn.lock and in fact run lifecycle scripts on our own package (prepare,postinstall).