Open
Conversation
models/entail1509.py
Outdated
| model.add_node(RepeatVector(spad), name='Wh_n_cross_e', input='Wh_n') | ||
| model.add_node(TimeDistributedDense(N,W_regularizer=l2(l2reg)), name='WY', input='Y') | ||
| model.add_node(Activation('tanh'), name='M', inputs=['Wh_n_cross_e', 'WY'], merge_mode='sum') | ||
| model.add_node(TimeDistributedDense(1,activation='softmax'), name='alpha', input='M') |
Contributor
Author
There was a problem hiding this comment.
Ok, it was a typo, replaced it with linear
Member
|
Thanks a lot for the update! I'm a lot happier I think, a bit wary about the ugly looking code in rnn_input but I understand the neccessity and we'll be able to throw away that complexity again with the Keras1.0 port. So it's okay. :) But I'm still a bit leery about the ptscorer business. I think the basic sanity check is:
The other problem I see is that we use completely different ptscoring strategies when the to_n is involved - I don't understand that. I think we discussed just making the output dimension a parameter of mlp_ptscorer? Would that be inferior to the current solution? |
Contributor
Author
EDIT:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The entailment model implementation is not 100% final, I had to replace some hardcoded code by the SequenceSplit layer and the performance is not as good as before.