fix(admin): recognize Brave in _chrome_running process check#287
Open
DanielKeith wants to merge 1 commit intobrowser-use:mainfrom
Open
fix(admin): recognize Brave in _chrome_running process check#287DanielKeith wants to merge 1 commit intobrowser-use:mainfrom
DanielKeith wants to merge 1 commit intobrowser-use:mainfrom
Conversation
The doctor's "chrome running" check used a process-name allowlist limited to chrome/edge, so Brave users saw a misleading FAIL line even when the harness connected to Brave successfully (the actual connection logic in daemon.get_ws_url already discovers Brave's user-data-dir). Add brave.exe (Windows) and Brave Browser / brave-browser / brave (POSIX process names across macOS and Linux) to the recognized set. Also broaden the docstring from "Chrome/Edge" to "Chromium-based browser".
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
browser-harness --doctorshows a misleading[FAIL] chrome running — start chrome/edgeline on machines where Brave is the only Chromium-based browser running, even when the harness has connected to Brave successfully. The actual connection logic indaemon.get_ws_url()already discovers Brave's user-data-dir (added in #284), so users see a healthy active connection alongside a contradictory "no chrome" failure.The cause is
_chrome_running()inadmin.py: its process-name allowlist is("chrome.exe", "msedge.exe")on Windows and("Google Chrome", "chrome", "chromium", "Microsoft Edge", "msedge")on POSIX — neither set matches Brave's process names.Change
_chrome_running(): addbrave.exe(Windows) andBrave Browser,brave-browser,brave(macOS / Linux) to the recognized setTests
test_chrome_running_detects_brave_on_windows— monkeypatchesplatform.system+subprocess.check_output, asserts_chrome_running()returnsTruetest_chrome_running_detects_brave_on_posix— same shape, Linux output withbrave-browserContext
Follow-up to #284, which made Brave's user-data-dir discoverable by the daemon's
get_ws_url(). With #284 in place, Brave connects fine but--doctorstill mis-reportschrome running.Summary by cubic
Fixes the misleading "[FAIL] chrome running" in
browser-harness --doctorwhen Brave is the active browser. The doctor check now recognizes Brave, so its output matches the actual connection.admin._chrome_running()to include Brave processes:brave.exe(Windows) andBrave Browser,brave-browser,brave(macOS/Linux).Written for commit 0685db2. Summary will update on new commits.