agency: Style A picked-button treatment (▶ BOLD_UPPER ◀)#105
Merged
MagMueller merged 1 commit intomainfrom May 8, 2026
Merged
Conversation
Magnus reviewed 5 candidate styles posted as cards in TG and picked Style A — bold uppercase letters wrapped with framing arrows. The trailing " ✓" suffix shipped in #104 was visible-but-subtle: easy to miss at phone scale next to a button label that already leads with a colorful icon. Style A makes the picked button visibly heavier than its siblings regardless of icon shape. Picked transformation: ✅ Yes → ▶ ✅ 𝗬𝗘𝗦 ◀ ⏭ Skip → ▶ ⏭ 𝗦𝗞𝗜𝗣 ◀ ✏️ Edit → ▶ ✏️ 𝗘𝗗𝗜𝗧 ◀ Send draft A → ▶ 𝗦𝗘𝗡𝗗 𝗗𝗥𝗔𝗙𝗧 𝗔 ◀ Bold uppercase uses Mathematical Sans-Serif Bold (U+1D5D4 onward). Emojis, digits, and punctuation pass through unchanged. Restoring the original label on un-pick uses the suggestion's buttons_json from agency.db (lossless). When buttons_json isn't available we fall back to lossy un-bold (case collapses to upper) — acceptable for the default Yes/Skip/Edit set since "YES" is fine. Module-level helpers added: _agency_bold_upper, _agency_unbold, _agency_pick_label, _agency_is_picked, _agency_strip_legacy_marks, _agency_unpick_label. Legacy "✓ " prefix (#103) and " ✓" suffix (#104) marks are still recognized + cleaned up on the next tap so in-flight cards from before this change tidy up automatically. Default kinds (action/dismiss/refine) keep reset_others=True so only the latest pick is highlighted. Custom kinds stay additive so variant-picker patterns ("Send draft A" + "Send draft B") still stack visibly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picked-button visibility iteration on top of #104.
Symptom
PR #104 shipped a trailing ` ✓` suffix on the picked button. Magnus tested it on his phone, said the mark was technically there but not unmistakable — at phone-button text size, an extra ✓ next to the button's own ✅ blends in. He wanted the entire button to look heavier.
Fix — Style A
Side-by-side comparison of 5 candidate styles posted as cards in TG; Magnus picked Style A: bold uppercase letters wrapped with framing arrows.
Bold uppercase via Mathematical Sans-Serif Bold (U+1D5D4 onward). Emojis, digits, punctuation pass through unchanged.
Restoring original labels on un-pick
Default kinds use `reset_others=True` — when the user changes their mind, the previously-picked button needs to revert to its original label. That requires knowing the original (we lose case info on bold-uppercase).
Approach: use the suggestion's `buttons_json` from `agency.db` for a lossless restore. When unavailable, fall back to lossy un-bold (case collapses to upper) — fine for the default Yes/Skip/Edit set since "YES" is acceptable.
Legacy mark cleanup
The `✓ ` prefix (PR #103) and ` ✓` suffix (PR #104) mark schemes are still recognized — `_agency_unpick_label` strips them on the next tap so cards posted before this rolled out tidy up automatically.
Test plan
Summary by cubic
Make picked buttons in agency cards unmistakable by switching to Style A: bold uppercase letters wrapped with arrows. Adds lossless label restore and cleans up legacy checkmark marks.
buttons_json; fallback to un-bold uppercase when missing.Written for commit 3b3ff9f. Summary will update on new commits.