-
Notifications
You must be signed in to change notification settings - Fork 28
feat: Support external CDP WebSocket URL for connecting to existing browsers #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
warmshao
wants to merge
2
commits into
browser-use:main
Choose a base branch
from
warmshao:feat/external-cdp-wss
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -135,10 +135,16 @@ const claudeCodeAdapter: EngineAdapter = { | |||||
| wrapPrompt(ctx: SpawnContext): string { | ||||||
| const lines: string[] = [ | ||||||
| 'You are driving a specific Chromium browser view on this machine.', | ||||||
| `Your target is CDP target_id=${ctx.targetId} on port ${ctx.cdpPort} (env BU_TARGET_ID / BU_CDP_PORT).`, | ||||||
| ]; | ||||||
| if (ctx.cdpUrl) { | ||||||
| lines.push(`You are connected to an external browser via CDP (env BU_DAEMON_SOCKET).`); | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3: Prompt mentions the wrong env var for external CDP WebSocket mode; it should refer to Prompt for AI agents
Suggested change
|
||||||
| } else { | ||||||
| lines.push(`Your target is CDP target_id=${ctx.targetId} on port ${ctx.cdpPort} (env BU_TARGET_ID / BU_CDP_PORT).`); | ||||||
| } | ||||||
| lines.push( | ||||||
| 'Read `./AGENTS.md` for how to drive the browser in this harness.', | ||||||
| 'Always read `./helpers.js` before writing scripts — that is where the functions live. Edit it if a helper is missing.', | ||||||
| ]; | ||||||
| ); | ||||||
| if (ctx.attachmentRefs.length > 0) { | ||||||
| lines.push('', 'The user attached these files for this task. Read each with your Read tool before acting:'); | ||||||
| for (const a of ctx.attachmentRefs) lines.push(` - ${a.relPath} (${a.mime}, ${a.size} bytes)`); | ||||||
|
|
@@ -176,8 +182,12 @@ const claudeCodeAdapter: EngineAdapter = { | |||||
| delete env.CLAUDE_CODE_USE_VERTEX; | ||||||
| delete env.CLAUDE_CODE_USE_FOUNDRY; | ||||||
| if (ctx.savedApiKey) env.ANTHROPIC_API_KEY = ctx.savedApiKey; | ||||||
| env.BU_TARGET_ID = ctx.targetId; | ||||||
| env.BU_CDP_PORT = String(ctx.cdpPort); | ||||||
| if (ctx.cdpUrl) { | ||||||
| env.BU_CDP_WS = ctx.cdpUrl; | ||||||
| } else { | ||||||
| env.BU_TARGET_ID = ctx.targetId; | ||||||
| env.BU_CDP_PORT = String(ctx.cdpPort); | ||||||
| } | ||||||
| return env; | ||||||
| }, | ||||||
|
|
||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Connection-mode env vars are added without clearing conflicting inherited vars, so stale BU_DAEMON_SOCKET / BU_CDP_WS / BU_TARGET_ID / BU_CDP_PORT values can force the helper into the wrong browser-connection mode.
Prompt for AI agents