-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(agent): enable prompt caching for the Anthropic CUA system prompt #2304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aditya-silna
wants to merge
2
commits into
browserbase:main
Choose a base branch
from
aditya-silna:fix/anthropic-cua-system-prompt-caching
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+91
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
packages/core/tests/unit/anthropic-cua-system-prompt-caching.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| import { describe, expect, it, vi, beforeEach } from "vitest"; | ||
| import { AnthropicCUAClient } from "../../lib/v3/agent/AnthropicCUAClient.js"; | ||
| import Anthropic from "@anthropic-ai/sdk"; | ||
|
|
||
| // Mock the Anthropic SDK's beta.messages.create method | ||
| vi.mock("@anthropic-ai/sdk", () => { | ||
| const mockCreate = vi.fn().mockResolvedValue({ | ||
| id: "test-id", | ||
| content: [{ type: "text", text: "test response" }], | ||
| usage: { input_tokens: 10, output_tokens: 20 }, | ||
| }); | ||
|
|
||
| return { | ||
| default: class MockAnthropic { | ||
| beta = { | ||
| messages: { | ||
| create: mockCreate, | ||
| }, | ||
| }; | ||
| }, | ||
| }; | ||
| }); | ||
|
|
||
| describe("AnthropicCUAClient system prompt caching", () => { | ||
| let mockCreate: ReturnType<typeof vi.fn>; | ||
|
|
||
| beforeEach(() => { | ||
| vi.clearAllMocks(); | ||
| // Get the mock create function from a new instance | ||
| const anthropic = new Anthropic({ apiKey: "test" }); | ||
| mockCreate = anthropic.beta.messages.create as ReturnType<typeof vi.fn>; | ||
| mockCreate.mockResolvedValue({ | ||
| id: "test-id", | ||
| content: [{ type: "text", text: "test response" }], | ||
| usage: { input_tokens: 10, output_tokens: 20 }, | ||
| }); | ||
| }); | ||
|
|
||
| it("should send the system prompt as a content block array with cache_control", async () => { | ||
| const instructions = "You are a helpful browser automation assistant."; | ||
| const client = new AnthropicCUAClient( | ||
| "anthropic", | ||
| "claude-opus-4-6", | ||
| instructions, | ||
| { | ||
| apiKey: "test-key", | ||
| }, | ||
| ); | ||
| client.setViewport(1280, 720); | ||
|
|
||
| await client.getAction([{ role: "user", content: "test" }]); | ||
|
|
||
| expect(mockCreate).toHaveBeenCalledWith( | ||
| expect.objectContaining({ | ||
| system: [ | ||
| { | ||
| type: "text", | ||
| text: instructions, | ||
| cache_control: { type: "ephemeral" }, | ||
| }, | ||
| ], | ||
| }), | ||
| ); | ||
| }); | ||
|
|
||
| it("should not set the system parameter when no instructions are provided", async () => { | ||
| const client = new AnthropicCUAClient( | ||
| "anthropic", | ||
| "claude-opus-4-6", | ||
| undefined, | ||
| { | ||
| apiKey: "test-key", | ||
| }, | ||
| ); | ||
| client.setViewport(1280, 720); | ||
|
|
||
| await client.getAction([{ role: "user", content: "test" }]); | ||
|
|
||
| const callArgs = mockCreate.mock.calls[0][0]; | ||
| expect(callArgs.system).toBeUndefined(); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: The new
systemcontent-block array withcache_controlis not verified by any unit test, even though the codebase already mocksgetAction's Anthropic SDK call and asserts on request parameters. Because the API call is typed asRecord<string, unknown>and uses@ts-expect-error, a regression in this shape would compile cleanly but fail at Anthropic at runtime. Adding a focused test that instantiatesAnthropicCUAClientwith non-emptyuserProvidedInstructionsand asserts on thesystemfield passed tomockCreatewould be straightforward given the existing test infrastructure.Prompt for AI agents