Honor store-specific enableOTP setting#261
Open
shinenelson wants to merge 3 commits into
Open
Conversation
erayd
requested changes
Apr 9, 2021
also, catch `enableOTP` in `fill` action to copy OTP token after filling login information reference : browserpass#261 (review)
to fetch the `enableOTP` setting reference : browserpass#261 (review)
Author
|
Ping @erayd if the review request was missed |
Collaborator
Not missed, just short on time. I'm expecting to have some time to spend working on Browserpass during the coming week, which will include this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Options allow for the
enableOTPfeature to be specified withinthe
.browserpass.json, but the feature is not enabled when theoption is specified within
.browserpass.jsonand not globally.This was because the check for the setting was only looking for the
global setting -
settings.enableOTPand did not check for the.browserpass.jsonsetting (settings.stores[*].settings.enableOTP).This changeset fixes that issue and properly honors the
enableOTPsetting specified within
.browserpass.jsonwith or without theglobal
enableOTPsetting.