Skip to content

chore: reverting truncate Element Changes #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abhi3685 merged 3 commits into from
Feb 16, 2026
Merged

chore: reverting truncate Element Changes #194

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1571930
merging 6.0.0
gaganmBrowserStack Feb 16, 2026
09a75cf
Resolving PR commits
gaganmBrowserStack Feb 16, 2026
58ff8ab
Resolving PR commits
gaganmBrowserStack Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions lib/core/utils/dq-element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,12 +281,17 @@ function getSourceOpt(element) {
}

function getSource(element) {
if (!element) {
if (!element?.outerHTML) {
return '';
}

// a11y-engine changes - use truncateElement which handles regex replacement
return truncateElement(element);
let source = element.outerHTML;
if (!source && typeof window.XMLSerializer === 'function') {
source = new window.XMLSerializer().serializeToString(element);
}
Comment on lines +288 to +290
Copy link
Collaborator

@Abhi3685 Abhi3685 Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if !source then you will early return from function right? this if check won't be executed anytime

Copy link
Collaborator Author

@gaganmBrowserStack gaganmBrowserStack Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Collaborator Author

@gaganmBrowserStack gaganmBrowserStack Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the original implementation before axe-core upgrade

// a11y-engine changes - use truncate which handles regex replacement
const regex = /\s*data-percy-[^=]+="[^"]*"/g; // Remove unwanted attributes
source = (source || '').replace(regex, '');
return truncate(source);
}

/**
Expand Down
Loading