Open
Conversation
borisrorsvort
requested changes
Oct 14, 2018
Member
borisrorsvort
left a comment
There was a problem hiding this comment.
Accordeon are not meant to display huge amount of texts. So I’d go more with a index / show pages and a «return to jobs» link or something.
Contributor
Author
|
@borisrorsvort I see what you mean. IMO though, I see the postings as "cards" and not really wall of texts, but it's true some of them are. If we go this way, then we could use the dynamic pages from middleman: https://middlemanapp.com/advanced/dynamic-pages/ I'm a bit torn as to how to characterize this content, thus if it needs dedicated resources. @otagi What do you think? |
Member
|
How how /jobs/:id ? ;) |
Member
|
@StanBoyet any progress? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue #88 .
The idea of the PR is to have a 1st version to display the positions on the website.
I feel like having an external link to a Github Repo is not enough of a proof of concept to learn anything from it and see if we can have an impact on this area.
On the other hand, I think that creating these markdowns files for each job is a good middle-ground for companies, as it's both easy and secured by the PR which is reviewed by the association.
This PR addresses this issue and tries to provide a first proof of concept to have these positions on the website.
This is a WIP for the moment, the view is "just" a dump of the parsed markdown in HTML. It works and markdown is being parsed, but it looks awful.
On the top of my head, here's what's missing:
# Titleto beh3instead ofh1and so one for the next title levels. Otherwise, we end up with multipleh1and it breaks the architectureBonus:
Edit: Add screenshot
